Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer(ticdc): update the logic of consumer. (#4129) #4470

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4129

What problem does this PR solve?

Issue Number: close #4128

Use kafka-consumer program to maintain the order relationship between commitTs and watermarkTs.

watermarkTs also known as ResolvedTs in TiCDC source code.

What is changed and how it works?

Modify the implementation detail of the kakfa-consumer program.

  • If meet ResolvedTs fallback, which means receive Resolved Event with Ts less than current ResolvedTs, just crash the consumer.
  • If meet Row Changed Event or DDL Event with Ts not greater than the globalResolvedTs, just ignore these events should already be seen.

After this PR, the consumer should still be running stable.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

`None`.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jan 25, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Jan 25, 2022
@overvenus overvenus added this to the v5.2.4 milestone Jan 25, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 23, 2022
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1f1bc18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2022
@ti-chi-bot ti-chi-bot merged commit 34e5660 into pingcap:release-5.2 Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants