-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve processor management and error handling #8657
Labels
affects-7.1
area/ticdc
Issues or PRs related to TiCDC.
type/enhancement
The issue or PR belongs to an enhancement.
Comments
ti-chi-bot
pushed a commit
that referenced
this issue
Apr 3, 2023
ti-chi-bot
pushed a commit
that referenced
this issue
Apr 12, 2023
/label affects-7.1 |
/remove-type feature |
ti-chi-bot
bot
added
type/enhancement
The issue or PR belongs to an enhancement.
and removed
type/feature
Issues about a new feature
labels
May 16, 2023
This was referenced May 16, 2023
/area ticdc |
This was referenced May 17, 2023
This was referenced May 18, 2023
/label affects-7.1 |
This was referenced May 22, 2023
16 tasks
/remove-label affects-6.5 |
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
May 30, 2023
…cap#8989) ref pingcap#8657 Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
May 30, 2023
ref pingcap#8657 Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
May 30, 2023
ref pingcap#8657 Signed-off-by: qupeng <qupeng@pingcap.com>
/close |
@nongfushanquan: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-7.1
area/ticdc
Issues or PRs related to TiCDC.
type/enhancement
The issue or PR belongs to an enhancement.
Is your feature request related to a problem?
sink
error occurs, it's better to letpuller
andredo
keep running;puller
error occurs, it's better to letsink
andredo
keep running;puller
doesn't emit errors, seems the only error can be "etcd context canceled"redo
error occurs, it's better to letsink
keep running;processor.Close
should be called correctly, or some stale context will be left. For example,SortEngine
instances.Processor
useerrCh
directly. When pushing an error into the channel, some different styles are used:default
branch inselect
; so the error can be dropped silenctly;case ctx.Done()
branch inselect
, which means the processor has been closed correctly.Describe the feature you'd like
I want to
Processor
lifetime from etcd session.Processor
can only be closed explicitly instead of canceling the etcd session's context;Processor.Close
will always be called correctly when destroying aProcessor
instance;Processor
;sink
,puller
andredo
, so that one component failure won't break whole system.Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response
The text was updated successfully, but these errors were encountered: