Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(processor/cdc): report module internal warnings #8983

Merged
merged 5 commits into from
May 19, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented May 17, 2023

What problem does this PR solve?

Issue Number: ref #8657

What is changed and how it works?

Report model internal warnings to users by api/v2/changefeeds/{ID}/status.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

example of api/v2/changefeeds/{ID}/status:

{"state":"normal","resolved_ts":441531555227631620,"checkpoint_ts":441531531923030068,"last_warning":{"time":"2023-05-17T15:40:12.504878333+08:00","addr":"10.2.7.2:8300","code":"CDC:ErrMySQLConnectionError","message":"[CDC:ErrMySQLConnectionError]fail to open MySQL connection: dial tcp 10.2.6.117:4000: connect: connection refused"}}

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
@nongfushanquan
Copy link
Contributor

/cc @sdojjy @asddongmen

@ti-chi-bot ti-chi-bot bot requested review from asddongmen and sdojjy May 18, 2023 01:33
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@sdojjy
Copy link
Member

sdojjy commented May 18, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6a0bdef

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 18, 2023

@hicqu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor Author

hicqu commented May 19, 2023

/retest-required

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9001.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9002.

hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants