-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api(ticdc): Check min service gc safepoint when resume changefeed #10546
api(ticdc): Check min service gc safepoint when resume changefeed #10546
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10546 +/- ##
================================================
+ Coverage 57.4842% 57.4939% +0.0097%
================================================
Files 849 848 -1
Lines 126099 126095 -4
================================================
+ Hits 72487 72497 +10
+ Misses 48195 48140 -55
- Partials 5417 5458 +41 |
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…hen-resume-changefeed' into check-min-service-gc-safepoint-when-resume-changefeed # Conflicts: # cdc/api/v2/api_helpers.go
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96, flowbehappy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #10463
What is changed and how it works?
currently, when the user resumes a failed changefeed, CDC does not do any GC safe point checking even if the data is already GCed. After this PR, when the user resumes a changefeed, CDC checks weather the current checkpoint ts is smaller than the min service gc safepoint or not. If smaller, ticdc open API will return an
ErrStartTsBeforeGC
error.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note