Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(ticdc): Check min service gc safepoint when resume changefeed #10546

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jan 25, 2024

What problem does this PR solve?

Issue Number: close #10463

What is changed and how it works?

currently, when the user resumes a failed changefeed, CDC does not do any GC safe point checking even if the data is already GCed. After this PR, when the user resumes a changefeed, CDC checks weather the current checkpoint ts is smaller than the min service gc safepoint or not. If smaller, ticdc open API will return an ErrStartTsBeforeGC error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #10546 (da6426e) into master (5d5ec56) will increase coverage by 0.0097%.
Report is 12 commits behind head on master.
The diff coverage is 62.5000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.7975% <62.5000%> (+0.0089%) ⬆️
dm 51.2376% <ø> (+0.0121%) ⬆️
engine 63.3999% <ø> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.4939% <62.5000%> (+0.0097%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10546        +/-   ##
================================================
+ Coverage   57.4842%   57.4939%   +0.0097%     
================================================
  Files           849        848         -1     
  Lines        126099     126095         -4     
================================================
+ Hits          72487      72497        +10     
+ Misses        48195      48140        -55     
- Partials       5417       5458        +41     

Co-authored-by: Flowyi <flowbehappy@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 26, 2024
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, flowbehappy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 03:04:39.616216733 +0000 UTC m=+1102721.180514425: ☑️ agreed by asddongmen.
  • 2024-01-26 05:09:53.787593616 +0000 UTC m=+1110235.351891322: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot merged commit 6600096 into pingcap:master Jan 26, 2024
28 checks passed
@sdojjy sdojjy deleted the check-min-service-gc-safepoint-when-resume-changefeed branch January 26, 2024 05:49
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 20, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10626.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10842.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc gets wrong pd gc safe point and causes changefeed exceeds gc ttl wrongly
5 participants