Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc gets wrong pd gc safe point and causes changefeed exceeds gc ttl wrongly #10463

Closed
AkiraXie opened this issue Jan 12, 2024 · 1 comment · Fixed by #10546
Closed

cdc gets wrong pd gc safe point and causes changefeed exceeds gc ttl wrongly #10463

AkiraXie opened this issue Jan 12, 2024 · 1 comment · Fixed by #10546
Assignees
@sdojjy
Labels
affects-6.1 affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.

Comments

@AkiraXie
Copy link

What did you do?

  1. cdc shows gc safe point is 446948031767773184
    img_v3_0271_e89e428e-48fb-4144-ba65-48c7ad127e9g
  2. but pd-ctl shows service-gc-safepoint is 446932460422299648
    img_v3_0271_4d0c46ee-f801-4c44-8c87-acbd7c2c910g
  3. and tikv metrics about gc is also same with service-gc-safepoint
    img_v3_0271_05ed7c1e-0056-4562-9daa-de46e8301b5g
  4. this may cause ticdc exceed gc ttl in error
    img_v3_0271_c7de1557-f026-4af7-a487-36449fc19afg

What did you expect to see?

No response

What did you see instead?

cdc gets wrong pd gc safe point and causes changefeed exceeds gc ttl wrongly

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

master
@AkiraXie AkiraXie added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Jan 12, 2024
@AkiraXie
Copy link
Author

/severity major

@CharlesCheung96 CharlesCheung96 self-assigned this Jan 14, 2024
@zhangjinpeng87 zhangjinpeng87 mentioned this issue Jan 17, 2024
Open
20 tasks
@sdojjy sdojjy assigned sdojjy and unassigned CharlesCheung96 Jan 18, 2024
@sdojjy sdojjy mentioned this issue Jan 25, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jan 26, 2024
@sdojjy
api(ticdc): Check min service gc safepoint when resume changefeed (#1…
6600096 
…0546)

close #10463
@sdojjy sdojjy mentioned this issue Jan 26, 2024
Merged
@ti-chi-bot ti-chi-bot mentioned this issue Feb 20, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 22, 2024
@ti-chi-bot
api(ticdc): Check min service gc safepoint when resume changefeed (#1…
d49cb0b 
…0546) (#10626)

close #10463
ti-chi-bot bot pushed a commit that referenced this issue Mar 11, 2024
@sdojjy
gc(ticdc): add min service gc safe point metrics (#10553)
0424aba 
ref #10463
@ti-chi-bot ti-chi-bot mentioned this issue Mar 11, 2024
Merged
This was referenced Mar 25, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 26, 2024
@ti-chi-bot
api(ticdc): Check min service gc safepoint when resume changefeed (#1…
b2d70b1 
…0546) (#10842)

close #10463
ti-chi-bot bot pushed a commit that referenced this issue Mar 26, 2024
@ti-chi-bot
gc(ticdc): add min service gc safe point metrics (#10553) (#10843)
c5b47c2 
ref #10463
ti-chi-bot bot pushed a commit that referenced this issue Apr 16, 2024
@ti-chi-bot
gc(ticdc): add min service gc safe point metrics (#10553) (#10751)
6930d87 
ref #10463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdojjy sdojjy

Labels
affects-6.1 affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api(ticdc): Check min service gc safepoint when resume changefeed sdojjy/tiflow
4 participants
@sdojjy @AkiraXie @CharlesCheung96 @ti-chi-bot