Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc(ticdc): add min service gc safe point metrics #10553

Merged
merged 3 commits into from
Mar 11, 2024
Merged

gc(ticdc): add min service gc safe point metrics #10553

merged 3 commits into from
Mar 11, 2024

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jan 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #10463

What is changed and how it works?

ticdc uses min service gc safe point to check whether data is GCed, this PR adds min service gc safe point metrics to ticdc dashboard, and with this metric, the user can easily understand why changefeed failed with ErrSnapshotLostByGC error

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 `None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

Merging #10553 (a806281) into master (b3d7106) will increase coverage by 0.3084%.
Report is 12 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 62.4551% <50.0000%> (+0.5434%) ⬆️
dm 51.2637% <ø> (+0.0383%) ⬆️
engine 63.4218% <ø> (+0.0494%) ⬆️
Flag Coverage Δ
unit 57.8620% <50.0000%> (+0.3084%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10553        +/-   ##
================================================
+ Coverage   57.5536%   57.8620%   +0.3084%     
================================================
  Files           850        853         +3     
  Lines        126767     127403       +636     
================================================
+ Hits          72959      73718       +759     
+ Misses        48369      48229       -140     
- Partials       5439       5456        +17

@flowbehappy flowbehappy self-requested a review January 26, 2024 09:35
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 26, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Jan 26, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Feb 4, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, flowbehappy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 09:55:17.555177734 +0000 UTC m=+1127359.119475438: ☑️ agreed by asddongmen.
  • 2024-02-05 03:10:43.813764224 +0000 UTC m=+153569.380534114: ☑️ agreed by CharlesCheung96.

@sdojjy
Copy link
Member Author

sdojjy commented Feb 6, 2024

/retest-required

3 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented Feb 6, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Feb 6, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Feb 7, 2024

/retest-required

@pingcap pingcap deleted a comment from ti-chi-bot bot Feb 7, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Feb 7, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented Feb 7, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Feb 8, 2024

/retest-required

@asddongmen
Copy link
Contributor

/retest

3 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

3 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@sdojjy
Copy link
Member Author

sdojjy commented Feb 19, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented Feb 21, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Feb 29, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Feb 29, 2024

/test dm-compatibility-test

@sdojjy
Copy link
Member Author

sdojjy commented Mar 1, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Mar 4, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Mar 4, 2024

/test dm-compatibility-test

@sdojjy
Copy link
Member Author

sdojjy commented Mar 4, 2024

/retest

@sdojjy
Copy link
Member Author

sdojjy commented Mar 6, 2024

/test dm-compatibility-test

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Mar 6, 2024
@sdojjy sdojjy removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Mar 6, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Mar 6, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Mar 11, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Mar 11, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 0424aba into pingcap:master Mar 11, 2024
27 of 28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10751.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 11, 2024
@sdojjy @ti-chi-bot
This is an automated cherry-pick of pingcap#10553
e0754fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2024
Merged
@sdojjy sdojjy deleted the add-min-service-gc-safepoint-metrics branch March 12, 2024 00:50
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10843.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 25, 2024
@sdojjy @ti-chi-bot
This is an automated cherry-pick of pingcap#10553
221196e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024
@ti-chi-bot
gc(ticdc): add min service gc safe point metrics (#10553) (#10843)
c5b47c2 
ref #10463
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@ti-chi-bot
gc(ticdc): add min service gc safe point metrics (#10553) (#10751)
6930d87 
ref #10463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdojjy @asddongmen @ti-chi-bot @flowbehappy @CharlesCheung96