Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: fix max-batch-size #1250

Merged
merged 4 commits into from
Dec 30, 2020
Merged

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Dec 29, 2020

What problem does this PR solve?

  • max-batch-size does not work.

What is changed and how it works?

  • fixed bug in passing max-batch-size to codec.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fixed bug in passing max-batch-size to codec.

@liuzix liuzix added status/ptal Could you please take a look? type/bugfix This PR fixes a bug. component/sink Sink component. labels Dec 29, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a unit test, thanks!

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2020
@zier-one
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 29, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@liuzix merge failed.

@zier-one
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@zier-one zier-one added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-5.0-rc labels Dec 30, 2020
@liuzix liuzix merged commit ade6c16 into pingcap:master Dec 30, 2020
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Dec 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1253

ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Dec 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #1254

ti-srebot added a commit that referenced this pull request Dec 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
amyangfei pushed a commit that referenced this pull request Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sink Sink component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants