-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink: fix max-batch-size #1250
Merged
Merged
sink: fix max-batch-size #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzix
added
status/ptal
Could you please take a look?
type/bugfix
This PR fixes a bug.
component/sink
Sink component.
labels
Dec 29, 2020
overvenus
approved these changes
Dec 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add a unit test, thanks!
LGTM |
ti-srebot
approved these changes
Dec 29, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 29, 2020
/run-all-tests |
@liuzix merge failed. |
/merge |
/run-all-tests |
zier-one
added
needs-cherry-pick-release-4.0
Should cherry pick this PR to release-4.0 branch.
needs-cherry-pick-5.0-rc
labels
Dec 30, 2020
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #1253 |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0-rc in PR #1254 |
ti-srebot
added a commit
that referenced
this pull request
Dec 30, 2020
amyangfei
pushed a commit
that referenced
this pull request
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/sink
Sink component.
needs-cherry-pick-release-4.0
Should cherry pick this PR to release-4.0 branch.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
status/ptal
Could you please take a look?
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
max-batch-size
does not work.What is changed and how it works?
max-batch-size
to codec.Check List
Tests
Related changes
Release note
max-batch-size
to codec.