Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: fix max-batch-size (#1250) #1254

Merged

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1250 to release-5.0-rc


What problem does this PR solve?

  • max-batch-size does not work.

What is changed and how it works?

  • fixed bug in passing max-batch-size to codec.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fixed bug in passing max-batch-size to codec.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added type/bugfix This PR fixes a bug. component/sink Sink component. status/ptal Could you please take a look? type/5.0-rc-cherry-pick labels Dec 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #1254 (844edfa) into release-5.0-rc (2be16a2) will not change coverage.
The diff coverage is 50.0000%.

@@                Coverage Diff                @@
##           release-5.0-rc      #1254   +/-   ##
=================================================
  Coverage         45.0530%   45.0530%           
=================================================
  Files                 128        128           
  Lines               12998      12998           
=================================================
  Hits                 5856       5856           
+ Misses               6495       6493    -2     
- Partials              647        649    +2     

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit d8f7400 into pingcap:release-5.0-rc Dec 30, 2020
@overvenus overvenus added this to the v5.0.0 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sink Sink component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants