kv-client: add stream binding background region worker, not enabled by default #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
amyangfei
force-pushed
the
kv-client-reduce-goroutine-2
branch
from
19f00ff to
ab83d81
Compare
Codecov Report
@@ Coverage Diff @@
## master #1397 +/- ##
================================================
- Coverage 48.6903% 47.5895% -1.1009%
================================================
Files 138 140 +2
Lines 13668 14043 +375
================================================
+ Hits 6655 6683 +28
- Misses 6317 6662 +345
- Partials 696 698 +2 |
amyangfei
force-pushed
the
kv-client-reduce-goroutine-2
branch
from
bb6aeb8 to
9d7ce1c
Compare
|
/run-all-tests |
amyangfei
changed the title
amyangfei
added
status/ptal
amyangfei
commented
Feb 18, 2021
|
/run-all-tests |
overvenus
reviewed
Feb 24, 2021
| @@ -375,13 +375,14 @@ func (w *regionWorker) evictAllRegions(ctx context.Context) error { | |||
| w.statesLock.Lock() | |||
| defer w.statesLock.Unlock() | |||
| for _, state := range w.regionStates { | |||
| log.Info("on region fail fired", zap.Reflect("state", state)) | |||
| state.lock.RLock() | |||
There was a problem hiding this comment.
I prefer the following, in case onRegionFail blocks.
state.lock.RLock()
singleRegionInfo := state.sri
state.lock.RUnlock()
There was a problem hiding this comment.
onRegionFail is non-blocking way
Besides, this code will be rewritten in later PR
|
LGTM |
ti-srebot
approved these changes
Feb 24, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
|
/run-integration-tests |
|
@amyangfei merge failed. |
|
|
/merge |
|
/run-all-tests |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Feb 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1455 |
amyangfei
added a commit
to ti-srebot/ticdc
that referenced
this pull request
Feb 26, 2021
ti-srebot
added a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Preparatory work for #1393
What is changed and how it works?
Add a new configuration item in changefeed config,Use a hard code const variablekv-client-v2, default false now, which will help us test the new feature. After refactor is stable, this config can be removed. (NOTE: add or remove a new item in changefeed config is both forward compatible and backward compatible)kvClientV2, which is simplercdc/kv/client.gocdc/kv/region_worker.go, the region worker is single goroutine now, and has a state lock for all regions that it manages. One gRPC stream <-> One region worker (multiple routines support in another pr) <-> One resolve lock routineNOTE:
Check List
Tests
Release note