-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv-client: add stream binding background region worker, not enabled by default (#1397) #1455
Merged
ti-srebot
merged 1 commit into
pingcap:release-4.0-pending
from
ti-srebot:release-4.0-5c4503cf90e9
Feb 26, 2021
Merged
kv-client: add stream binding background region worker, not enabled by default (#1397) #1455
ti-srebot
merged 1 commit into
pingcap:release-4.0-pending
from
ti-srebot:release-4.0-5c4503cf90e9
Feb 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
ti-srebot
added
component/kv-client
TiKV kv log client component.
status/ptal
Could you please take a look?
type/4.0-cherry-pick
labels
Feb 25, 2021
I will resolve conflicts later |
amyangfei
force-pushed
the
release-4.0-5c4503cf90e9
branch
from
February 26, 2021 05:53
6b156e4
to
f673880
Compare
/run-all-tests |
/run-integration-tests |
amyangfei
approved these changes
Feb 26, 2021
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 26, 2021
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0-pending #1455 +/- ##
========================================================
Coverage ? 47.6432%
========================================================
Files ? 142
Lines ? 14193
Branches ? 0
========================================================
Hits ? 6762
Misses ? 6723
Partials ? 708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/kv-client
TiKV kv log client component.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
status/ptal
Could you please take a look?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1397 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1455
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Preparatory work for #1393
What is changed and how it works?
Add a new configuration item in changefeed config,Use a hard code const variablekv-client-v2
, default false now, which will help us test the new feature. After refactor is stable, this config can be removed. (NOTE: add or remove a new item in changefeed config is both forward compatible and backward compatible)kvClientV2
, which is simplercdc/kv/client.go
cdc/kv/region_worker.go
, the region worker is single goroutine now, and has a state lock for all regions that it manages. One gRPC stream <-> One region worker (multiple routines support in another pr) <-> One resolve lock routineNOTE:
Check List
Tests
Release note