-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink/mysql: adjust producer/consumer exit sequence to avoid goroutine leak #1929
Conversation
/run-all-tests |
/run-all-tests |
/run-unit-tests |
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 32673df
|
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
================================================
+ Coverage 53.8503% 54.2801% +0.4297%
================================================
Files 155 163 +8
Lines 16479 17336 +857
================================================
+ Hits 8874 9410 +536
- Misses 6655 6918 +263
- Partials 950 1008 +58 |
In response to a cherrypick label: new pull request created: #1945. |
In response to a cherrypick label: new pull request created: #1946. |
What problem does this PR solve?
Fix a goroutine leak bug, where the sink worker has exited, but more txns are sent to txn channel of sink worker.
And the producer will wait for the txn to be consumed forever.
What is changed and how it works?
Add a cleanup mechanism for sink worker.
Check List
Tests
Release note