-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink/mysql: adjust producer/consumer exit sequence to avoid goroutine leak (#1929) #1945
sink/mysql: adjust producer/consumer exit sequence to avoid goroutine leak (#1929) #1945
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 75495e6
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1945 +/- ##
===================================================
- Coverage 53.7661% 53.7518% -0.0144%
===================================================
Files 153 163 +10
Lines 15958 17365 +1407
===================================================
+ Hits 8580 9334 +754
- Misses 6475 7046 +571
- Partials 903 985 +82 |
This is an automated cherry-pick of #1929
What problem does this PR solve?
Fix a goroutine leak bug, where the sink worker has exited, but more txns are sent to txn channel of sink worker.
And the producer will wait for the txn to be consumed forever.
What is changed and how it works?
Add a cleanup mechanism for sink worker.
Check List
Tests
Release note