Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: provide more information on sorter IO errors (#1969) #1976

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1969

What problem does this PR solve?

  • The sorter's IO errors are not wrapped and provides no useful information as to how to resolve the problem.

What is changed and how it works?

  • When the sorter encounters an IO error, it will wrap it into an information error.

Check List

Tests

  • Unit test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Make sorter IO errors more user-friendly.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jun 7, 2021
@ti-chi-bot ti-chi-bot requested a review from zier-one June 7, 2021 08:01
@liuzix liuzix added this to the v4.0.14 milestone Jun 7, 2021
@liuzix
Copy link
Contributor

liuzix commented Jun 21, 2021

/run-unit-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@amyangfei
Copy link
Contributor

need to fix make check

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 6, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 300af32

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1976 (a0afbe6) into release-4.0 (753073a) will increase coverage by 0.1931%.
The diff coverage is 62.5769%.

@@                 Coverage Diff                 @@
##           release-4.0      #1976        +/-   ##
===================================================
+ Coverage      53.7661%   53.9592%   +0.1931%     
===================================================
  Files              153        163        +10     
  Lines            15958      17339      +1381     
===================================================
+ Hits              8580       9356       +776     
- Misses            6475       6981       +506     
- Partials           903       1002        +99     

@ti-chi-bot ti-chi-bot merged commit 564be42 into pingcap:release-4.0 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants