-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter: provide more information on sorter IO errors #1969
Conversation
/run-all-tests |
/lgtm |
@asddongmen: Please use GitHub review feature instead of For the reason we drop support to the commands, see also this page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d3c0141
|
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
================================================
+ Coverage 53.8746% 53.9970% +0.1223%
================================================
Files 155 164 +9
Lines 16479 17388 +909
================================================
+ Hits 8878 9389 +511
- Misses 6652 6994 +342
- Partials 949 1005 +56 |
In response to a cherrypick label: new pull request created: #1976. |
In response to a cherrypick label: new pull request created: #1977. |
In response to a cherrypick label: new pull request created: #1978. |
Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Side effects
Related changes
Release note