Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: provide more information on sorter IO errors #1969

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 7, 2021

What problem does this PR solve?

  • The sorter's IO errors are not wrapped and provides no useful information as to how to resolve the problem.

What is changed and how it works?

  • When the sorter encounters an IO error, it will wrap it into an information error.

Check List

Tests

  • Unit test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Make sorter IO errors more user-friendly.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 7, 2021
@liuzix liuzix added needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Jun 7, 2021
@liuzix liuzix requested a review from overvenus June 7, 2021 05:34
@liuzix
Copy link
Contributor Author

liuzix commented Jun 7, 2021

/run-all-tests

@asddongmen
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@asddongmen: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei added this to the v5.1.0 milestone Jun 7, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 7, 2021

/run-all-tests

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d3c0141

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1969 (bfc255e) into master (a1067a0) will increase coverage by 0.1223%.
The diff coverage is 64.8188%.

@@               Coverage Diff                @@
##             master      #1969        +/-   ##
================================================
+ Coverage   53.8746%   53.9970%   +0.1223%     
================================================
  Files           155        164         +9     
  Lines         16479      17388       +909     
================================================
+ Hits           8878       9389       +511     
- Misses         6652       6994       +342     
- Partials        949       1005        +56     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1976.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1977.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1978.

amyangfei pushed a commit that referenced this pull request Jun 7, 2021
Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants