Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: provide more information on sorter IO errors (#1969) #1978

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1969

What problem does this PR solve?

  • The sorter's IO errors are not wrapped and provides no useful information as to how to resolve the problem.

What is changed and how it works?

  • When the sorter encounters an IO error, it will wrap it into an information error.

Check List

Tests

  • Unit test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Make sorter IO errors more user-friendly.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jun 7, 2021
@ti-chi-bot ti-chi-bot requested a review from zier-one June 7, 2021 08:02
@ti-chi-bot ti-chi-bot requested a review from liuzix June 7, 2021 08:02
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@amyangfei amyangfei added this to the v5.1.0 milestone Jun 7, 2021
@amyangfei amyangfei merged commit f5e8078 into pingcap:release-5.1 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants