Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/client: add cached regions metric in region router #2994

Merged
merged 6 commits into from
Oct 13, 2021
Merged

kv/client: add cached regions metric in region router #2994

merged 6 commits into from
Oct 13, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Oct 9, 2021 •
edited
Loading

What problem does this PR solve?

Close #2985

What is changed and how it works?

  • Add metric to record cached region count in region router.
  • Add Grafana metric to estimate incremental remaining time, sample:

screenshot-20211009-143953

screenshot-20211009-144004

Check

List

Tests

  • Unit test
  • Integration test

Release note 

Add metrics to observe incremental scan remaining time

@amyangfei amyangfei added the component/kv-client TiKV kv log client component. label Oct 9, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 9, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2021
@amyangfei amyangfei added the component/metrics-logging Metrics and logging component. label Oct 9, 2021
@amyangfei amyangfei added status/ptal Could you please take a look? needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Oct 9, 2021
overvenus
overvenus approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2021
@overvenus overvenus changed the title kv/client: add cached regions metric in region rounter kv/client: add cached regions metric in region router Oct 9, 2021
@Rustin170506
Copy link
Member

Sorry I didn't get to review it today! I'll review it tomorrow!

@amyangfei
Copy link
Contributor Author

ptal, thanks @hi-rustin

Rustin170506
Rustin170506 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pingcap/ticdc/blob/7cc6bfc4eb96350d8029f32d8c08a62950214a42/cdc/kv/token_region.go#L134

How about you fix this typo if you don't mind!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ea8fcb7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 2650d14 into pingcap:master Oct 13, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3032.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3033.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3034.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3035.

@amyangfei amyangfei deleted the cached-region-size-metric branch October 13, 2021 10:02
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
kv/client: add cached regions metric in region router (#2994) (#3032)
25ed6dc
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
kv/client: add cached regions metric in region router (#2994) (#3034)
9de9ee6
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
kv/client: add cached regions metric in region router (#2994) (#3035)
5de69d5
ti-chi-bot added a commit that referenced this pull request Oct 14, 2021
@ti-chi-bot
kv/client: add cached regions metric in region router (#2994) (#3033)
fb5a805
@overvenus overvenus mentioned this pull request Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@overvenus overvenus overvenus approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.

Add metrics to observe incremental scan remaining time
4 participants
@amyangfei @ti-chi-bot @Rustin170506 @overvenus