Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/client: add cached regions metric in region router (#2994) #3035

Merged
merged 5 commits into from
Oct 14, 2021
Merged

kv/client: add cached regions metric in region router (#2994) #3035

merged 5 commits into from
Oct 14, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2994

What problem does this PR solve?

Close #2985

What is changed and how it works?

  • Add metric to record cached region count in region router.
  • Add Grafana metric to estimate incremental remaining time, sample:

screenshot-20211009-143953

screenshot-20211009-144004

Check

List

Tests

  • Unit test
  • Integration test

Release note 

Add metrics to observe incremental scan remaining time

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Oct 13, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2021
Merged
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 14, 2021
@amyangfei amyangfei added this to the v5.2.2 milestone Oct 14, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3fb3ab3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 5de69d5 into pingcap:release-5.2 Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @amyangfei @nongfushanquan