-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): correctly handle the state after the old owner is upgraded to the new owner #3553
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold Waiting for test. |
/run-all-tests |
/cc @liuzix @overvenus Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️ |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have integration tests for this?
I will try to add a test case on test-infra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold I'll probably write a better solution. See https://docs.google.com/document/d/1ex7PQ8AWtdpFf5VMJ9-TMdk4xM5m1S68tkP6aKYHR60/edit#heading=h.rtyrqbrdc0zd for a specific discussion (in Chinese). |
What problem does this PR solve?
part of https://github.com/pingcap/ticdc/issues/3473
What is changed and how it works?
correctly display the status of the old owner's paused tasks.
Check List
Tests
Code changes
None
Side effects
None
Related changes
Release note