Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv,puller(ticdc): add changefeed ID to kv client #4373

Merged
merged 6 commits into from
Jan 18, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

It is difficult to debug kv client problems when there are many changefeeds, because logs are mixed up.

Issue Number: ref #3288

What is changed and how it works?

Add changefeed field to kv client log.

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. component/metrics-logging Metrics and logging component. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2022
@overvenus overvenus added the component/kv-client TiKV kv log client component. label Jan 18, 2022
@overvenus overvenus changed the title Kv add changefeed kv,puller(ticdc): add changefeed ID to kv client Jan 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #4373 (a951cef) into master (ab62e6b) will decrease coverage by 0.2147%.
The diff coverage is 46.5807%.

Flag Coverage Δ
cdc 59.1195% <54.9723%> (-0.4964%) ⬇️
dm 52.0766% <41.8856%> (+0.0110%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4373        +/-   ##
================================================
- Coverage   55.5183%   55.3035%   -0.2148%     
================================================
  Files           495        495                
  Lines         61151      61280       +129     
================================================
- Hits          33950      33890        -60     
- Misses        23789      23984       +195     
+ Partials       3412       3406         -6     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2022
@3AceShowHand 3AceShowHand self-requested a review January 18, 2022 05:08
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2022
@3AceShowHand
Copy link
Contributor

LGTM at the moment.

For further logging refinement, we would take https://github.com/pingcap/tiflow/blob/4bfa080ecce6c57a670af290a764e2654e9361bb/cdc/scheduler/schedule_dispatcher.go#L97-L107 as an reference.

@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86b68a9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@ti-chi-bot ti-chi-bot merged commit 0538d37 into pingcap:master Jan 18, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4389.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4390.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4391.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4392.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4393.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants