-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv,puller(ticdc): add changefeed ID to kv client #4373
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4373 +/- ##
================================================
- Coverage 55.5183% 55.3035% -0.2148%
================================================
Files 495 495
Lines 61151 61280 +129
================================================
- Hits 33950 33890 -60
- Misses 23789 23984 +195
+ Partials 3412 3406 -6 |
LGTM at the moment. For further logging refinement, we would take |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 86b68a9
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4389. |
In response to a cherrypick label: new pull request created: #4390. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4391. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4392. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4393. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4394. |
What problem does this PR solve?
It is difficult to debug kv client problems when there are many changefeeds, because logs are mixed up.
Issue Number: ref #3288
What is changed and how it works?
Add changefeed field to kv client log.
Check List
Related changes
Release note