Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(ticdc): rollup of TiCDC log PRs (#4373) (#4235) (#4217) (#4375) #4394

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 18, 2022

This is an automated cherry-pick of #4373 #4235 #4217 #4375

What problem does this PR solve?

It is difficult to debug kv client problems when there are many changefeeds, because logs are mixed up.

Issue Number: ref #3288

What is changed and how it works?

Add changefeed field to kv client log.

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jan 18, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2022
@overvenus overvenus force-pushed the cherry-pick-4373-to-release-5.4 branch from dba0a55 to 1727ff3 Compare January 18, 2022 16:03
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2022
@overvenus overvenus changed the title kv,puller(ticdc): add changefeed ID to kv client (#4373) *(ticdc): rollup of TiCDC logs PRs (#4373) (#4235) (#4217) Jan 18, 2022
@overvenus overvenus changed the title *(ticdc): rollup of TiCDC logs PRs (#4373) (#4235) (#4217) *(ticdc): rollup of TiCDC log PRs (#4373) (#4235) (#4217) Jan 18, 2022
@overvenus overvenus added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jan 21, 2022
@overvenus overvenus changed the title *(ticdc): rollup of TiCDC log PRs (#4373) (#4235) (#4217) *(ticdc): rollup of TiCDC log PRs (#4373) (#4235) (#4217) (#4375) Feb 8, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 9, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 9, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2022
@overvenus
Copy link
Member

Merged by #5542

@overvenus overvenus closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants