-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): use generic slice allocator #5038
sink(ticdc): use generic slice allocator #5038
Conversation
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run_jenkins-ticdc/verify |
/run-all-tests |
@ngaut: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5038 +/- ##
================================================
+ Coverage 56.1240% 56.1307% +0.0067%
================================================
Files 522 525 +3
Lines 65325 67496 +2171
================================================
+ Hits 36663 37886 +1223
- Misses 25094 25878 +784
- Partials 3568 3732 +164 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 131377b
|
@sunxiaoguang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Xiaoguang Sun sunxiaoguang@gmail.com
What problem does this PR solve?
Issue Number: close #5037
What is changed and how it works?
Use generic in go 1.18 to replace type specific allocators into a generic allocator implementation.
Check List
Tests
Release note