Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): use generic slice allocator #5038

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

sunxiaoguang
Copy link
Contributor

@sunxiaoguang sunxiaoguang commented Mar 26, 2022

Signed-off-by: Xiaoguang Sun sunxiaoguang@gmail.com

What problem does this PR solve?

Issue Number: close #5037

What is changed and how it works?

Use generic in go 1.18 to replace type specific allocators into a generic allocator implementation.

Check List

Tests

  • Unit test
  • Integration test

Release note

`None`

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2022
@sunxiaoguang
Copy link
Contributor Author

/run_jenkins-ticdc/verify

@sunxiaoguang
Copy link
Contributor Author

/run-all-tests

@overvenus overvenus added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Mar 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@overvenus overvenus changed the title Use generic slice allocator sink(ticdc): use generic slice allocator Mar 31, 2022
@ti-chi-bot
Copy link
Member

@ngaut: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #5038 (131377b) into master (687e248) will increase coverage by 0.0067%.
The diff coverage is 57.5415%.

Flag Coverage Δ
cdc 61.5050% <52.2293%> (+0.9064%) ⬆️
dm 51.9043% <84.3373%> (-0.5653%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5038        +/-   ##
================================================
+ Coverage   56.1240%   56.1307%   +0.0067%     
================================================
  Files           522        525         +3     
  Lines         65325      67496      +2171     
================================================
+ Hits          36663      37886      +1223     
- Misses        25094      25878       +784     
- Partials       3568       3732       +164     

@overvenus overvenus added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 1, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 131377b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@ti-chi-bot
Copy link
Member

@sunxiaoguang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6948589 into pingcap:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use generic to implement slice allocator
5 participants