Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools(both): make gocov compatible with go1.18 #5050

Merged
merged 2 commits into from
Mar 29, 2022
Merged

tools(both): make gocov compatible with go1.18 #5050

merged 2 commits into from
Mar 29, 2022

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Mar 28, 2022

What problem does this PR solve?

Issue Number: ref #5037

#5038 used go1.18 generic, but gocov didn't work.

What is changed and how it works?

replace github.com/axw/gocov => github.com/jdemeyer/gocov v1.0.1-0.20220316125951-e6ea120e4bdf

After axw/gocov#91 is merged, we can remove this replace and upgrade gocov.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 28, 2022
@sleepymole
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #5050 (bfb1b23) into master (687e248) will decrease coverage by 0.3764%.
The diff coverage is 55.8441%.

Flag Coverage Δ
cdc 61.1998% <48.8328%> (+0.6011%) ⬆️
dm 51.3926% <87.3949%> (-1.0769%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5050        +/-   ##
================================================
- Coverage   56.1240%   55.7475%   -0.3765%     
================================================
  Files           522        526         +4     
  Lines         65325      67420      +2095     
================================================
+ Hits          36663      37585       +922     
- Misses        25094      26116      +1022     
- Partials       3568       3719       +151     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@lance6716
Copy link
Contributor

/cc @hi-rustin

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8838a3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@ti-chi-bot
Copy link
Member

@gozssky: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sleepymole
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit 1a95ac2 into pingcap:master Mar 29, 2022
@sleepymole sleepymole deleted the patch-gocov branch October 12, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants