Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(cdc): backport stale metrics fix to 5.4 #5260

Merged
merged 3 commits into from
Apr 25, 2022
Merged

owner(cdc): backport stale metrics fix to 5.4 #5260

merged 3 commits into from
Apr 25, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Apr 24, 2022

What problem does this PR solve?

Issue Number: ref #4774

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Release note 

Fix TiCDC incorrectly display stale metrics data on dashboard.

@liuzix liuzix added type/bugfix This PR fixes a bug. component/metrics-logging Metrics and logging component. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. component/owner Owner component. labels Apr 24, 2022
@liuzix liuzix added this to the v5.4.1 milestone Apr 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Apr 24, 2022

/run-integration-tests

@liuzix liuzix mentioned this pull request Apr 24, 2022
Closed
@ti-chi-bot
Copy link
Member

@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
@asddongmen
Copy link
Contributor 

[2022-04-24T13:31:53.519Z]         	Test:       	TestNoFinishOperationBeforeSyncIsReceived

This test is failed.
Should this #5011 be cherr-picked to 5.4 release branch too?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2022

/run-unit-tests
/run-verify

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2022

/run-unit-tests
/run-verify

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 25, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 235bbc8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2022

/run-kafka-integration-test
/run-unit-tests
/run-verify

@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2022

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit 1cbf7f7 into pingcap:release-5.4 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. component/owner Owner component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @ti-chi-bot @asddongmen @Rustin170506 @nongfushanquan @VelocityLight