Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(cdc): clean up metrics when owner resigns #4998

Merged
merged 7 commits into from
Mar 28, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Mar 23, 2022

What problem does this PR solve?

Issue Number: close #4774

What is changed and how it works?

  • Owner must clean up its metrics when it stops.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix stale metrics data when TiCDC owner switches.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Mar 23, 2022

/run-leak-tests
/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #4998 (00dfeb5) into master (687e248) will decrease coverage by 0.3347%.
The diff coverage is 51.7304%.

Flag Coverage Δ
cdc 61.0971% <43.7570%> (+0.4984%) ⬆️
dm 51.5158% <85.6459%> (-0.9537%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4998        +/-   ##
================================================
- Coverage   56.1240%   55.7892%   -0.3348%     
================================================
  Files           522        523         +1     
  Lines         65325      66744      +1419     
================================================
+ Hits          36663      37236       +573     
- Misses        25094      25824       +730     
- Partials       3568       3684       +116     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@amyangfei
Copy link
Contributor

/merge

1 similar comment
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00dfeb5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. label Mar 25, 2022
@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 809ad60 into pingcap:master Mar 28, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5043.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5044.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5045.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5046.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5047.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5048.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TiCDC] Owner fails to clean up stale metrics leading to incorrect display in dashboard
5 participants