Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(cdc): backport stale metrics fix to 5.3 #5894

Merged
merged 3 commits into from
Jun 16, 2022
Merged

owner(cdc): backport stale metrics fix to 5.3 #5894

merged 3 commits into from
Jun 16, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 16, 2022

What problem does this PR solve?

Issue Number: ref #4774

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Release note 

Fix TiCDC incorrectly display stale metrics data on dashboard.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 16, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Jun 16, 2022

/run-integration-tests

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2022
@nongfushanquan
Copy link
Contributor

/cc @asddongmen @hi-rustin

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022
Rustin170506
Rustin170506 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

cdc/owner/owner.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2022
@liuzix @Rustin170506
Update cdc/owner/owner.go
6195466 
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 16, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Jun 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6195466

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Jun 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4097b09

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@liuzix
Copy link
Contributor Author

liuzix commented Jun 16, 2022

/run-unit-tests
/run-integration-tests

@liuzix
Copy link
Contributor Author

liuzix commented Jun 16, 2022

/run-verify

@ti-chi-bot ti-chi-bot merged commit dcb5b39 into pingcap:release-5.3 Jun 16, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@liuzix @ti-chi-bot @nongfushanquan @asddongmen @Rustin170506 @VelocityLight @heibaijian