syncer(dm): fix the data race issue (#5881)

[ti-chi-bot]

This is an automated cherry-pick of #5881

What problem does this PR solve?

Issue Number: close #4811

What is changed and how it works?

The Result() function now returns a new copy of the process result instead of directly returning the pointer without the lock, which may cause data race when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read.

To solve the problem, first call Marshal() on the original process result, which will generate an intermediate process result. Then call Unmarshal() on the intermediate one and generate a new process result. Now the new process result is a copy of the original one, thus it can be the return parameter of Result().

Check List

Tests

• Unit test

Questions

Will it cause performance regression or break compatibility?

No. The type of the return parameter is not changed, which is still *pb.ProcessResult, so this update will not affect those functions that call Result().

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

Fix the issue of the possible data race that might occur when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read. #4811 

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[niubell]

/run-unit-test

[niubell]

/run-verify

[lance6716]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2efa85f

[lance6716]

/run-unit-test

[lance6716]

/hold

please fix git conflict @lyzx2001

[lance6716]

/unhold

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: caa2265

[lance6716]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a8ad306

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.