syncer(dm): fix the data race issue #5881

lyzx2001 · 2022-06-15T04:41:50Z

What problem does this PR solve?

Issue Number: close #4811

What is changed and how it works?

The Result() function now returns a new copy of the process result instead of directly returning the pointer without the lock, which may cause data race when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read.

To solve the problem, first call Marshal() on the original process result, which will generate an intermediate process result. Then call Unmarshal() on the intermediate one and generate a new process result. Now the new process result is a copy of the original one, thus it can be the return parameter of Result().

Check List

Tests

Unit test

Questions

Will it cause performance regression or break compatibility?

No. The type of the return parameter is not changed, which is still *pb.ProcessResult, so this update will not affect those functions that call Result().

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

Fix the issue of the possible data race that might occur when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read. #4811

ti-chi-bot · 2022-06-15T04:41:51Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

D3Hunter
lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-06-15T04:41:56Z

All committers have signed the CLA.

buchuitoudegou

I don't know if we should check a potential data race issue in such way (manually writing and reading in different routines). Perhaps just checking if the returned result is a snapshot of the original one is sufficient🤔

buchuitoudegou · 2022-06-15T08:23:19Z

dm/dm/worker/subtask_test.go

+				_, _ = tempQueryStatusResponse.Marshal()
+			}
+		}()
+		_ = st.markResultCanceled()


Suggested change

_ = st.markResultCanceled()

st.markResultCanceled()

I checked by writing and reading in different routines because in issue #4811 the data race was found in the two functions markResultCanceled() and Marshal(). So here I manually reproduce the encountered data race and fix it.

[2022-03-08T09:00:20.317Z] Write at 0x00c006394380 by goroutine 199: [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SubTask).markResultCanceled() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/subtask.go:470 +0x257 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SubTask).Pause() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/subtask.go:498 +0x54 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).OperateSubTask() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:564 +0x52c [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).operateSubTaskStage() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:743 +0x1fe [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).operateSubTaskStageWithoutConfig() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:762 +0x1b7 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).handleSubTaskStage() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:698 +0x658 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).observeSubtaskStage() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:656 +0x844 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).EnableHandleSubtasks.func1() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:438 +0x138 [2022-03-08T09:00:20.317Z] [2022-03-08T09:00:20.317Z] Previous read at 0x00c006394380 by goroutine 289: [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/pb.(*ProcessResult).Size() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:5308 +0x7a [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/pb.(*SubTaskStatus).Size() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:5008 +0x34d [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/pb.(*QueryStatusResponse).Size() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:4765 +0x1f7 [2022-03-08T09:00:20.317Z] github.com/pingcap/tiflow/dm/dm/pb.(*QueryStatusResponse).Marshal() [2022-03-08T09:00:20.317Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:3027 +0x54 [2022-03-08T09:00:20.317Z] google.golang.org/grpc/encoding/proto.codec.Marshal() [2022-03-08T09:00:20.317Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/encoding/proto/proto.go:70 +0x23b [2022-03-08T09:00:20.317Z] google.golang.org/grpc/encoding/proto.(*codec).Marshal() [2022-03-08T09:00:20.317Z] <autogenerated>:1 +0x64 [2022-03-08T09:00:20.317Z] google.golang.org/grpc.encode() [2022-03-08T09:00:20.317Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/rpc_util.go:545 +0x74 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).sendResponse() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:869 +0x184 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).processUnaryRPC() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1117 +0xb34 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).handleStream() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1405 +0x138b [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).serveStreams.func1.1() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:746 +0xe6 [2022-03-08T09:00:20.318Z] [2022-03-08T09:00:20.318Z] Goroutine 199 (running) created at: [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*SourceWorker).EnableHandleSubtasks() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/source_worker.go:434 +0xbcc [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*Server).enableHandleSubtasks() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/server.go:673 +0x195 [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*Server).operateSourceBound() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/server.go:659 +0x2e8 [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*Server).handleSourceBound() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/server.go:583 +0x511 [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*Server).observeSourceBound() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/server.go:407 +0x108b [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/worker.(*Server).Start.func4() [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/worker/server.go:170 +0x114 [2022-03-08T09:00:20.318Z] [2022-03-08T09:00:20.318Z] Goroutine 289 (running) created at: [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).serveStreams.func1() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:744 +0xb8 [2022-03-08T09:00:20.318Z] google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/internal/transport/http2_server.go:442 +0x1850 [2022-03-08T09:00:20.318Z] google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/internal/transport/http2_server.go:483 +0x49c [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).serveStreams() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:742 +0x1c7 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).handleRawConn.func1() [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:703 +0x4c [2022-03-08T09:00:20.318Z] ================== [2022-03-08T09:00:20.318Z] panic: runtime error: index out of range [-1] [2022-03-08T09:00:20.318Z] [2022-03-08T09:00:20.318Z] goroutine 1179 [running]: [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/pb.(*QueryStatusResponse).MarshalToSizedBuffer(0xc0059ddb40, 0xc00647c000, 0x272, 0x272, 0x150129f, 0xc000d1e000, 0xc000df5648) [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:3082 +0x952 [2022-03-08T09:00:20.318Z] github.com/pingcap/tiflow/dm/dm/pb.(*QueryStatusResponse).Marshal(0xc0059ddb40, 0x61b5f40, 0xc0059ddb40, 0x7fb4e4351e08, 0xc0059ddb40, 0x1) [2022-03-08T09:00:20.318Z] /home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/dm/pb/dmworker.pb.go:3029 +0xa5 [2022-03-08T09:00:20.318Z] google.golang.org/grpc/encoding/proto.codec.Marshal(0x61b5f40, 0xc0059ddb40, 0x1, 0xc00006d040, 0xc0059ddb40, 0xc004fd33d0, 0xc0059ddb60) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/encoding/proto/proto.go:70 +0x23c [2022-03-08T09:00:20.318Z] google.golang.org/grpc.encode(0x7fb4e45c3af8, 0xa295638, 0x61b5f40, 0xc0059ddb40, 0xa295638, 0x7, 0xf, 0x0, 0x6338d08) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/rpc_util.go:545 +0x75 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).sendResponse(0xc000924000, 0x74bcbb8, 0xc000b88000, 0xc006478100, 0x61b5f40, 0xc0059ddb40, 0x0, 0x0, 0xc006bf034f, 0x0, ...) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:869 +0x185 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).processUnaryRPC(0xc000924000, 0x74bcbb8, 0xc000b88000, 0xc006478100, 0xc000f68a50, 0x90b0840, 0x0, 0x0, 0x0) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1117 +0xb35 [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).handleStream(0xc000924000, 0x74bcbb8, 0xc000b88000, 0xc006478100, 0x0) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:1405 +0x138c [2022-03-08T09:00:20.318Z] google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc00022b240, 0xc000924000, 0x74bcbb8, 0xc000b88000, 0xc006478100) [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:746 +0xe7 [2022-03-08T09:00:20.318Z] created by google.golang.org/grpc.(*Server).serveStreams.func1 [2022-03-08T09:00:20.318Z] /go/pkg/mod/google.golang.org/grpc@v1.29.1/server.go:744 +0xb9

Modified. The unit test changed to just checking if the returned result is a snapshot of the original one.

buchuitoudegou · 2022-06-15T08:27:24Z

dm/dm/worker/subtask.go

@@ -552,7 +552,10 @@ func (st *SubTask) markResultCanceled() bool {
 func (st *SubTask) Result() *pb.ProcessResult {
 	st.RLock()
 	defer st.RUnlock()
-	return st.result
+	tempProcessResult, _ := st.result.Marshal()


It'd better check the error just for the sake of security.

Got it. I have modified the code and added the error handling.

buchuitoudegou · 2022-06-15T08:27:38Z

dm/dm/worker/subtask.go

-	return st.result
+	tempProcessResult, _ := st.result.Marshal()
+	newProcessResult := &pb.ProcessResult{}
+	_ = newProcessResult.Unmarshal(tempProcessResult)


ditto. Or:

Suggested change

_ = newProcessResult.Unmarshal(tempProcessResult)

newProcessResult.Unmarshal(tempProcessResult)

Is it necessary to decode and encode it again? What about deep copying the object?

*a = *b // a, b are pointers

Actually, it is necessary to decode and encode it, because Result() originally returns a pointer without the lock, which may cause data race when multiple functions are executing concurrently and calling Result(). In this case, deep copying would still return a pointer without the lock, which does not solve the problem. Here decoding and encoding again return a new copy of the process result, so that when multiple functions are calling Result() concurrently and using the returned pointer to modify things, they would be modifying the new copy, which has no effect on the original pointer, thus avoiding the potential data race.

Modified using deep copy.

_ = newProcessResult.Unmarshal(tempProcessResult)
Here I cannot delete _ =, because 'make check' would fail and report error return value is not checked. Since it is guaranteed here that Unmarshal() will not return an error, so we can just ignore it.

buchuitoudegou · 2022-06-15T08:28:45Z

dm/dm/worker/subtask_test.go

+		st.result.IsCanceled = false
+		go func() {
+			for i := 0; i < 10; i++ {
+				_, _ = tempQueryStatusResponse.Marshal()


The for loop is just to increase the chances of running into data race, because one or two tests may not be able to fully check the issue. We'd better wait until these routines stop before exiting the test.

buchuitoudegou · 2022-06-15T08:31:36Z

dm/dm/worker/subtask_test.go

+	}
+	cfg := &config.SubTaskConfig{
+		Name: "test-subtask-race",
+		ValidatorCfg: config.ValidatorConfig{


Will this issue do anything with the validator?

Not sure. Sorry I am not quite familiar with the validator.

buchuitoudegou · 2022-06-15T08:32:49Z

dm/dm/worker/subtask_test.go

+	tempQueryStatusResponse.SubTaskStatus[0] = &tempSubTaskStatus
+	for i := 0; i < 10; i++ {
+		st.result.IsCanceled = false
+		go func() {


Should we wait until these routines stop before exiting this test or they are just detached?

The for loop is just to increase the chances of running into data race, because one or two tests may not be able to fully check the issue. We'd better wait until these routines stop before exiting the test.

buchuitoudegou · 2022-06-16T10:10:39Z

dm/dm/worker/subtask.go

+	tempProcessResult := st.result
+	Errors := []*pb.ProcessError{}
+	Detail := []byte{}
+	immProcessResult := pb.ProcessResult{
+		IsCanceled: false,
+		Errors:     Errors,
+		Detail:     Detail,
+	}
+	var newProcessResult *pb.ProcessResult
+	newProcessResult = &immProcessResult


Suggested change

tempProcessResult := st.result

Errors := []*pb.ProcessError{}

Detail := []byte{}

immProcessResult := pb.ProcessResult{

IsCanceled: false,

Errors: Errors,

Detail: Detail,

}

var newProcessResult *pb.ProcessResult

newProcessResult = &immProcessResult

var newProcessResult *pb.ProcessResult

newProcessResult = &pb.ProcessResult{}

buchuitoudegou · 2022-06-16T10:15:07Z

dm/dm/worker/subtask.go

+	}
+	var newProcessResult *pb.ProcessResult
+	newProcessResult = &immProcessResult
+	*newProcessResult = *tempProcessResult


The pb.ProcessResult.Errors is an array of pointers, which should be deep copied as well.

Suggested change

*newProcessResult = *tempProcessResult

*newProcessResult = *st.Result

Modified back to Marshal() and Unmarshal(), which is less efficient than deep copy but easier to maintain (have been discussed).

buchuitoudegou · 2022-06-16T10:24:46Z

dm/dm/worker/subtask_test.go

+	var check bool
+	if st.Result() == st.result {
+		check = false
+	} else {
+		check = true


Suggested change

var check bool

if st.Result() == st.result {

check = false

} else {

check = true

require.NotEqual(t, st.Result(), st.result)

Only checking this is not sufficient (e.g. the pointers in the Errors slice).

D3Hunter · 2022-06-17T02:26:18Z

README.md

@@ -1,9 +1,12 @@
 # TiFlow

+[![LICENSE](https://img.shields.io/github/license/pingcap/tiflow.svg)](https://github.com/pingcap/tiflow/blob/master/LICENSE)


see a lot of changes about readme and cdc, is that related to fixing this bug?

She possibly rebase-merged the master🤔

Right. I rebase-merged the master into my branch, probably shouldn't have done so. Only the changes in (*SubTask).Result() in dm/dm/worker/subtask.go and TestSubtaskRace() in dm/dm/worker/subtask_test.go are related to fixing this bug. I have fixed this problem, and now this PR should only contain the changes above.

codecov-commenter · 2022-06-20T06:51:33Z

Codecov Report

Merging #5881 (2e56fa2) into master (6a451ea) will increase coverage by 0.3948%.
The diff coverage is 59.6810%.

Flag	Coverage Δ
cdc	`62.4657% <44.2953%> (+0.4857%)`	⬆️
dm	`51.9826% <29.3103%> (+0.0524%)`	⬆️
engine	`63.9114% <77.1551%> (+1.7268%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5881        +/-   ##
================================================
+ Coverage   57.0764%   57.4713%   +0.3948%     
================================================
  Files           682        677         -5     
  Lines         80224      79765       -459     
================================================
+ Hits          45789      45842        +53     
+ Misses        30146      29679       -467     
+ Partials       4289       4244        -45

lance6716 · 2022-06-20T04:06:31Z

dm/dm/worker/subtask_test.go

+
+func TestSubtaskRace(t *testing.T) {
+	// to test data race of Marshal() and markResultCanceled()
+	Errors := []*pb.ProcessError{}


generally local variables should not be public (capitalized)

lance6716 · 2022-06-20T06:56:14Z

dm/dm/worker/subtask_test.go

+	tempSubTaskStatus := pb.SubTaskStatus{}
+	tempSubTaskStatus.Result = st.Result()
+	tempQueryStatusResponse.SubTaskStatus[0] = &tempSubTaskStatus
+	for i := 0; i < 10; i++ {


Did you try that we can remove this loop and race detector still work?

I just tried removing this loop and restoring the original Result(), and ran the unit test several times. It turned out that the race detector still worked. I have removed this loop.

lyzx2001 · 2022-06-20T09:47:32Z

/run-verify

D3Hunter · 2022-06-21T04:03:55Z

/merge

ti-chi-bot · 2022-06-21T04:03:58Z

This pull request has been accepted and is ready to merge.

Commit hash: 2e56fa2

lyzx2001 · 2022-06-21T07:33:35Z

/run-dm-integration-test

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-06-21T09:05:19Z

In response to a cherrypick label: new pull request created: #5959.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-06-21T09:05:57Z

In response to a cherrypick label: new pull request created: #5960.

close pingcap#4811

ti-chi-bot · 2022-06-21T09:06:35Z

In response to a cherrypick label: new pull request created: #5961.

close #4811

fix the data race issue

b0a1081

ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 15, 2022

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2022

lance6716 added the area/dm Issues or PRs related to DM. label Jun 15, 2022

Merge branch 'master' into fixing

da24ce3

ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 15, 2022

buchuitoudegou reviewed Jun 15, 2022

View reviewed changes

lance6716 changed the title ~~fix the data race issue~~ syncer(dm): fix the data race issue Jun 15, 2022

lyzx2001 added 2 commits June 16, 2022 12:41

update the fixing of data race issue

46c7326

update the fixing of data race issue

bac0290

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022

lyzx2001 added 2 commits June 16, 2022 13:01

update the fixing of data race issue

3df51cb

syncer(dm): update the fixing of data race

c51de33

buchuitoudegou reviewed Jun 16, 2022

View reviewed changes

D3Hunter reviewed Jun 17, 2022

View reviewed changes

Merge branch 'master' into fixing

7e4e37e

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2022

lyzx2001 added 2 commits June 17, 2022 19:35

syncer(dm) update the fixing of data race issue

82bcc93

fix the nil pointer dereference issue

3ecbac5

lance6716 reviewed Jun 20, 2022

View reviewed changes

remove the outer loop in unit test

2e56fa2

lance6716 approved these changes Jun 20, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022

D3Hunter approved these changes Jun 21, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022

ti-chi-bot added 3 commits June 21, 2022 12:04

Merge branch 'master' into fixing

0ec251f

Merge branch 'master' into fixing

cd3c626

Merge branch 'master' into fixing

d3694b8

Merge branch 'master' into fixing

ccfff85

ti-chi-bot merged commit 86780b1 into pingcap:master Jun 21, 2022

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022

This is an automated cherry-pick of pingcap#5881

e9f7580

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 21, 2022

syncer(dm): fix the data race issue (#5881) #5959

Merged

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022

This is an automated cherry-pick of pingcap#5881

2efa85f

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 21, 2022

syncer(dm): fix the data race issue (#5881) #5960

Merged

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022

syncer(dm): fix the data race issue (pingcap#5881)

d852907

close pingcap#4811

ti-chi-bot mentioned this pull request Jun 21, 2022

syncer(dm): fix the data race issue (#5881) #5961

Merged

ti-chi-bot added a commit that referenced this pull request Jun 28, 2022

syncer(dm): fix the data race issue (#5881) (#5961)

cb8d87f

close #4811

ti-chi-bot added a commit that referenced this pull request Jul 4, 2022

syncer(dm): fix the data race issue (#5881) (#5959)

781562b

close #4811

ti-chi-bot added a commit that referenced this pull request Jul 11, 2022

syncer(dm): fix the data race issue (#5881) (#5960)

d7905cb

close #4811

	_ = newProcessResult.Unmarshal(tempProcessResult)
	newProcessResult.Unmarshal(tempProcessResult)

	newProcessResult = tempProcessResult
	newProcessResult = st.Result

		@@ -1,9 +1,12 @@
		# TiFlow

		[![LICENSE](https://img.shields.io/github/license/pingcap/tiflow.svg)](https://github.com/pingcap/tiflow/blob/master/LICENSE)

syncer(dm): fix the data race issue #5881

syncer(dm): fix the data race issue #5881

Conversation

lyzx2001 commented Jun 15, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

ti-chi-bot commented Jun 15, 2022 • edited Loading

sre-bot commented Jun 15, 2022 • edited Loading

buchuitoudegou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 20, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lyzx2001 commented Jun 20, 2022

D3Hunter commented Jun 21, 2022

ti-chi-bot commented Jun 21, 2022

lyzx2001 commented Jun 21, 2022

ti-chi-bot commented Jun 21, 2022

ti-chi-bot commented Jun 21, 2022

ti-chi-bot commented Jun 21, 2022

ti-chi-bot commented Jun 15, 2022 •

edited

Loading

sre-bot commented Jun 15, 2022 •

edited

Loading

codecov-commenter commented Jun 20, 2022 •

edited

Loading