-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncer(dm): fix the data race issue (#5881) #5961
syncer(dm): fix the data race issue (#5881) #5961
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d852907
|
/run-dm-integration-test |
/run-dm-integration-test |
1 similar comment
/run-dm-integration-test |
This is an automated cherry-pick of #5881
What problem does this PR solve?
Issue Number: close #4811
What is changed and how it works?
The Result() function now returns a new copy of the process result instead of directly returning the pointer without the lock, which may cause data race when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read.
To solve the problem, first call Marshal() on the original process result, which will generate an intermediate process result. Then call Unmarshal() on the intermediate one and generate a new process result. Now the new process result is a copy of the original one, thus it can be the return parameter of Result().
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. The type of the return parameter is not changed, which is still *pb.ProcessResult, so this update will not affect those functions that call Result().
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note