Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer(dm): fix the data race issue (#5881) #5961

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5881

What problem does this PR solve?

Issue Number: close #4811

What is changed and how it works?

The Result() function now returns a new copy of the process result instead of directly returning the pointer without the lock, which may cause data race when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read.

To solve the problem, first call Marshal() on the original process result, which will generate an intermediate process result. Then call Unmarshal() on the intermediate one and generate a new process result. Now the new process result is a copy of the original one, thus it can be the return parameter of Result().

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No. The type of the return parameter is not changed, which is still *pb.ProcessResult, so this update will not affect those functions that call Result().

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

Fix the issue of the possible data race that might occur when multiple functions are executing concurrently, some calling Result() and writing into some variables that other functions are trying to read. #4811 

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Jun 21, 2022
@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 21, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 28, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d852907

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@lance6716
Copy link
Contributor

/run-dm-integration-test
/run-integration-test
/run-kafka-integration-test
/run-dm-compatibility-test

@lance6716
Copy link
Contributor

/run-dm-integration-test

1 similar comment
@lance6716
Copy link
Contributor

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit cb8d87f into pingcap:release-6.1 Jun 28, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants