Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: flush redo meta in owner instead of processor #6313

Merged
merged 11 commits into from
Jul 18, 2022
Merged

cdc: flush redo meta in owner instead of processor #6313

merged 11 commits into from
Jul 18, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jul 16, 2022

What problem does this PR solve?

Issue Number: close #6277

What is changed and how it works?

Flush redo meta in owner instead of processor.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

hicqu added 2 commits July 17, 2022 01:06
@hicqu
only flush redo meta in owner
e365ad1 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
fix tests
d85d2ad 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 16, 2022
@hicqu
fix check
d80d81a 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Jul 16, 2022

/run-integration-test

@hicqu
fix
fb8815e 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Jul 16, 2022

/run-integration-test

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022 •
edited
Loading

Codecov Report

Merging #6313 (eb444db) into master (bcb773a) will increase coverage by 0.2638%.
The diff coverage is 72.5654%.

Flag Coverage Δ
cdc 65.9693% <68.6170%> (+0.0954%) ⬆️
dm 51.8842% <77.0491%> (+0.0114%) ⬆️
engine 64.7108% <78.8104%> (+1.6140%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6313        +/-   ##
================================================
+ Coverage   59.0443%   59.3082%   +0.2638%     
================================================
  Files           736        746        +10     
  Lines         85346      85575       +229     
================================================
+ Hits          50392      50753       +361     
+ Misses        30483      30329       -154     
- Partials       4471       4493        +22

@hicqu
a little changes
06c7f4c 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Jul 17, 2022

/run-all-tests

@hicqu
Copy link
Contributor Author

hicqu commented Jul 17, 2022

/run-leak-test

@hicqu
address comments
f6599ed 
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added 2 commits July 17, 2022 20:41
@hicqu
address comments
82d6364 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Merge branch 'master' into redo-ddl-fix
eb444db
@nongfushanquan
Copy link
Contributor

/cc @liuzix

@ti-chi-bot ti-chi-bot requested a review from liuzix July 18, 2022 01:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 18, 2022
zhaoxinyu
zhaoxinyu reviewed Jul 18, 2022
View reviewed changes
cdc/redo/common/redo.go Outdated Show resolved Hide resolved
hicqu and others added 2 commits July 18, 2022 11:21
@hicqu
address comments
5a0d277 
Signed-off-by: qupeng <qupeng@pingcap.com>
@liuzix
Merge branch 'master' into redo-ddl-fix
a1347da
@liuzix
Copy link
Contributor

liuzix commented Jul 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a1347da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@nongfushanquan
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit cdb4506 into pingcap:master Jul 18, 2022
@hicqu hicqu mentioned this pull request Jul 18, 2022
Merged
@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/lebel

@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/lebel needs-cherry-pick-release-6.1
/run-cherry-picker

@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/cherry-pick release-6.1

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 18, 2022
@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#6313
0e9da48 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Merged
@ti-chi-bot
Copy link
Member

@hicqu: new pull request created: #6321.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 18, 2022
@hicqu
This is an automated cherry-pick of pingcap#6313
3d0678b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 18, 2022
Closed
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@ti-chi-bot
cdc: flush redo meta in owner instead of processor (#6313) (#6321)
99692a0 
close #6277
This was referenced Jul 21, 2022
Closed
Closed
@hicqu hicqu mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc redo meta can be broken if cdc fails when executing DDLs
7 participants
@hicqu @ti-chi-bot @codecov-commenter @nongfushanquan @liuzix @zhaoxinyu @CharlesCheung96