-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: ignore redo log meta regress for restarting #6320
Conversation
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6320 +/- ##
================================================
+ Coverage 59.0443% 65.4152% +6.3709%
================================================
Files 736 507 -229
Lines 85346 46295 -39051
================================================
- Hits 50392 30284 -20108
+ Misses 30483 13630 -16853
+ Partials 4471 2381 -2090 |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8748831
|
/run-kafka-integration-test |
/run-all-tests |
/run-integration-test |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #6327. |
It's closed as it doesn't fix the problem at root exactly. It's replaced by #6321 . |
What problem does this PR solve?
Issue Number: ref #6277
What is changed and how it works?
After #6313 is merged, cdc instance can panic if redo meta regresses. It can really happend when a cdc instance restarts.
This PR ignored redo meta regress.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note