Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: ignore redo log meta regress for restarting #6320

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jul 18, 2022

What problem does this PR solve?

Issue Number: ref #6277

What is changed and how it works?

After #6313 is merged, cdc instance can panic if redo meta regresses. It can really happend when a cdc instance restarts.

This PR ignored redo meta regress.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu added 2 commits July 18, 2022 13:46
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #6320 (8748831) into master (bcb773a) will increase coverage by 6.3709%.
The diff coverage is 74.2424%.

Flag Coverage Δ
cdc 66.0140% <72.1562%> (+0.1401%) ⬆️
dm ?
engine 63.4827% <78.8104%> (+0.3859%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6320        +/-   ##
================================================
+ Coverage   59.0443%   65.4152%   +6.3709%     
================================================
  Files           736        507       -229     
  Lines         85346      46295     -39051     
================================================
- Hits          50392      30284     -20108     
+ Misses        30483      13630     -16853     
+ Partials       4471       2381      -2090     

@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/run-all-tests

@liuzix
Copy link
Contributor

liuzix commented Jul 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8748831

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/run-kafka-integration-test

@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/run-all-tests

@hicqu
Copy link
Contributor Author

hicqu commented Jul 18, 2022

/run-integration-test
/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit e351bac into pingcap:master Jul 18, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 18, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6327.

@hicqu hicqu deleted the ignore-log-meta-regress branch July 18, 2022 09:43
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 18, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Aug 18, 2022

It's closed as it doesn't fix the problem at root exactly. It's replaced by #6321 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants