changefeed (ticdc): fix owner stuck when closing a changefeed (#6882) #6893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6882
What problem does this PR solve?
Issue Number: close #6859
What is changed and how it works?
Use
c.isReleased
instead ofc.initialized
to determine whether we should release resources of a changefeed, otherwise if an error occurs in the middle ofc.initialize()
, thec.initialized
will befalse
, so the resources of a changefeed would not be release expectantly, which leads to some goroutines leak and can not be cancel byc.cancel()
.Check List
Tests
cli changefeed [ pasue ,resume ,remove ]
this changefeed, all commands work well which indicate the owner is working normally.Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note