-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p(ticdc): use a larger max receive message size #8005
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
pkg/config/messages.go
Outdated
if c.MaxRecvMsgSize == 0 { | ||
c.MaxRecvMsgSize = defaultMaxRecvMsgSize | ||
} | ||
if c.MaxRecvMsgSize <= 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if c.MaxRecvMsgSize <= 0 { | |
if c.MaxRecvMsgSize < 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks this 2 case can be switched, check <0
and return the error first, then check if it's 0
.
maybe this can help Lines 124 to 133 in 73bb333
|
Signed-off-by: Neil Shen <overvenus@gmail.com>
pkg/cmd/server/server_test.go
Outdated
@@ -205,6 +205,7 @@ func TestParseCfg(t *testing.T) { | |||
ServerMaxPendingMessageCount: 102400, | |||
ServerAckInterval: config.TomlDuration(time.Millisecond * 100), | |||
ServerWorkerPoolSize: 4, | |||
MaxRecvMsgSize: 268435456, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaxRecvMsgSize: 268435456, | |
MaxRecvMsgSize: 256 * 1024 * 1024, |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8b583d9
|
/run-engine-integration-test |
/run-engine-integration-test |
@overvenus: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
close pingcap#8004 Signed-off-by: Neil Shen <overvenus@gmail.com>
close pingcap#8004 Signed-off-by: Neil Shen <overvenus@gmail.com>
What problem does this PR solve?
Issue Number: close #8004
What is changed and how it works?
Use a larger max receive message size to address ResourceExhausted issue.
Check List
Tests
Setup a changefeed that replicate 72k tables.
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note