Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p(ticdc): use a larger max receive message size (#8005) #8013

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8005

What problem does this PR solve?

Issue Number: close #8004

What is changed and how it works?

Use a larger max receive message size to address ResourceExhausted issue.

Check List

Tests

  • Unit test
  • Manual test
    Setup a changefeed that replicate 72k tables.

image

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

Fix an issue that checkpoint can not advance when replicating many tables.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ticdc Issues or PRs related to TiCDC. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jan 3, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 4, 2023
@overvenus overvenus force-pushed the cherry-pick-8005-to-release-6.1 branch from b949269 to b33937c Compare January 6, 2023 07:39
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 6, 2023
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b33937c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2023
close pingcap#8004

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the cherry-pick-8005-to-release-6.1 branch from 690fe10 to 1bcd5bd Compare January 6, 2023 07:43
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2023
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1bcd5bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@9613e94). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 36df4b5 differs from pull request most recent head 09fe861. Consider uploading reports for the commit 09fe861 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 61.9836% <0.0000%> (?)
dm 52.1981% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #8013   +/-   ##
================================================
  Coverage               ?   56.6432%           
================================================
  Files                  ?        548           
  Lines                  ?      71938           
  Branches               ?          0           
================================================
  Hits                   ?      40748           
  Misses                 ?      27313           
  Partials               ?       3877           

@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member

/run-kafka-integration-test

1 similar comment
@overvenus
Copy link
Member

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit ee2a385 into pingcap:release-6.1 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants