Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*(all): update dependencies on tidb and pd. #8126
*(all): update dependencies on tidb and pd. #8126
Changes from 26 commits
dde7691
f8011ce
022862a
72c0087
053c101
34b01cd
9c47ff4
dee9636
cb0aa87
9a0d3db
7bc84de
37f27f7
4181e92
9a86faa
c46cd35
712b87a
2affa94
7ad35b2
ae2cb54
4cd5a82
6148e9b
ccaf0cb
1a060a7
310f0fe
696fa26
775f97a
c42dab2
4b2e19b
03e6f46
f1628fd
3fd5f58
b35f4e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone cross compile macOS TiCDC on a linux machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only GOOS matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! You are right, only GOOS matters, but no matter set
CGO_ENABLED=0
orCGO_ENABLED=1
runGOOS=darwin make cdc
fails.I revert related changes and run the following commands:
Do you have any idea to fix this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pingcap/tidb#41165
use
CGO_ENABLED=1
is the only way to build on darwin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but can't build a darwin cdc on linux machine.