Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick batch update optimization (#8069) (#8191) (#8452) #8727

Merged
merged 5 commits into from
Apr 13, 2023
Merged

cherry pick batch update optimization (#8069) (#8191) (#8452) #8727

merged 5 commits into from
Apr 13, 2023

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #8084

What is changed and how it works?

cherry-pick #8069, #8191 and #8452

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Enable batch update SQL when downstream is TiDB.

@amyangfei amyangfei added area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Apr 3, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added the tide/merge-method-merge Denotes a PR that should be merge by tide when it merges. label Apr 3, 2023
@amyangfei amyangfei changed the title Cherry pick batch update optimization cherry pick batch update optimization #8069, #8191 and #8452 Apr 3, 2023
@amyangfei amyangfei removed the tide/merge-method-merge Denotes a PR that should be merge by tide when it merges. label Apr 3, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/test verify

@amyangfei
Copy link
Contributor Author

/run-kafka-integration-test

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-kafka-integration-test

@amyangfei amyangfei added type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. and removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Apr 3, 2023
@amyangfei amyangfei changed the title cherry pick batch update optimization #8069, #8191 and #8452 cherry pick batch update optimization (#8069) (#8191) (#8452) Apr 3, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 35a7073

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023
@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 95b5db3 into pingcap:release-6.1 Apr 13, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@hicqu hicqu Awaiting requested review from hicqu

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @ti-chi-bot @asddongmen @nongfushanquan @VelocityLight