Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter (ticdc): simplify filter interface and apply event filter rule in ddlPuller (#9549) #9569

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 14, 2023

This is an manual cherry-pick of #9549 and #9577

What problem does this PR solve?

Issue Number: close #9531 #9571

What is changed and how it works?

  1. The ShouldIgnoreDDLEvent() method has been removed from the filter interface and its functionality has been integrated into the ShouldDiscardDDL() method. This makes the filter interface more readable and consistent.
  2. DDLs can be skipped in the ddlPuller by setting eventFilter or IgnoreTxnStartTs in the filter configuration. This allows users to control which DDLs are processed, which can be useful for performance or debugging purposes. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.
  3. Add a detailed error message to inform the user how to skip an DDL when it can not be handle by TiCDC.
    image

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen asddongmen force-pushed the cherry-pick-9549-to-release-7.1 branch from bec3840 to e2950ee Compare September 19, 2023 07:16
@asddongmen asddongmen removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@asddongmen asddongmen self-requested a review September 19, 2023 07:26
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 19, 2023
@asddongmen
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot merged commit 7b33ca9 into pingcap:release-7.1 Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants