Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter (ticdc): add a lock to protect the parser from being called concurrently. #9577

Merged

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9571

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 06:27:01.263433311 +0000 UTC m=+612385.812449294: ☑️ agreed by 3AceShowHand.
  • 2023-08-15 06:52:11.408667719 +0000 UTC m=+613895.957683706: ☑️ agreed by CharlesCheung96.

@nongfushanquan
Copy link
Contributor

/test dm-integration-test

1 similar comment
@nongfushanquan
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 8d3997a into pingcap:master Aug 21, 2023
3 checks passed
@asddongmen asddongmen added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9617.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC changefeed error "[CDC:ErrConvertDDLToEventTypeFailed]failed to convert ddl "
5 participants