Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server, backend: graceful shutdown #159

Merged
merged 3 commits into from
Dec 26, 2022
Merged

server, backend: graceful shutdown #159

merged 3 commits into from
Dec 26, 2022

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Dec 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #161

Problem Summary:
Support graceful shutdown so that when TiProxy is scaled in or upgraded, the connections can wait for the end of transactions before disconnecting.

What is changed and how it works:

  • Add a configuration 'graceful-wait-before-shutdown`
  • Wait for the end of the transaction when it's notified to shut down

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xhebox
xhebox reviewed Dec 26, 2022
View reviewed changes
pkg/proxy/backend/backend_conn_mgr.go Outdated Show resolved Hide resolved
pkg/proxy/proxy_test.go Outdated Show resolved Hide resolved
pkg/proxy/backend/backend_conn_mgr.go Outdated Show resolved Hide resolved
@xhebox xhebox merged commit f725184 into pingcap:main Dec 26, 2022
@djshow832 djshow832 deleted the shutdown branch December 26, 2022 09:32
@xhebox xhebox mentioned this pull request Dec 27, 2022
Closed
@djshow832 djshow832 mentioned this pull request Dec 27, 2022
Merged
8 tasks
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
@djshow832 @xhebox
server, backend: graceful shutdown (pingcap#159)
ea86d42
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 @xhebox
server, backend: graceful shutdown (pingcap#159)
e233115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djshow832 @xhebox