backend: fix connection won't close if graceful shutdown starts during handshake #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #161
Problem Summary:
statusConnected
orstatusHandshaked
overridesstatusNotifyClose
, which makesstatusNotifyClose
not work.SIGINT
signal, thecmd.Context()
is done, and it will stop some components, such as the goroutine which processessignalGracefulClose
. Thus, theBackendConnMgr
won't shutdown immediately.What is changed and how it works:
connStatus
tocloseStatus
and it only manages the status of closing.SQLServer
. I've checked the code of the gateway, it won't affect the gateway.Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code
graceful-shutdown=10 and stop the TiProxy
graceful-shutdown=10, send a
begin
statement and stop the TiProxygraceful-shutdown=10, send a
begin
statement, stop the TiProxy, and send acommit
statementgraceful-shutdown=0, send a
begin
statement and stop the TiProxyNotable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.