Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: set the Y axis of some metrics to logBase=2 #561

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #542

Problem Summary:
Using log2 on the Y axis of some metrics is clearer, especially duration and CPS.

What is changed and how it works:
Update metrics json to add logBase=2.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox June 19, 2024 04:20
@ti-chi-bot ti-chi-bot bot added the size/M label Jun 19, 2024
Copy link

ti-chi-bot bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-19 04:55:28.682137933 +0000 UTC m=+177055.167626764: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 9a589dd into pingcap:main Jun 19, 2024
4 of 5 checks passed
@djshow832 djshow832 deleted the logBase branch June 19, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set some of the Y axis of grafana metrics to log2
2 participants