Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: set the Y axis of some metrics to logBase=2 #561

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions pkg/metrics/grafana/tiproxy_summary.json
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -766,7 +766,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -852,7 +852,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -938,7 +938,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1024,7 +1024,7 @@
{
"format": "short",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1110,7 +1110,7 @@
{
"format": "short",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1196,7 +1196,7 @@
{
"format": "short",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1296,7 +1296,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1488,7 +1488,7 @@
{
"format": "short",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1588,7 +1588,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1674,7 +1674,7 @@
{
"format": "short",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1794,7 +1794,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1880,7 +1880,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down Expand Up @@ -1966,7 +1966,7 @@
{
"format": "s",
"label": null,
"logBase": 1,
"logBase": 2,
"max": null,
"min": null,
"show": true
Expand Down
16 changes: 15 additions & 1 deletion pkg/metrics/grafana/tiproxy_summary.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ local uptimeP = graphPanel.new(
datasource=myDS,
legend_rightSide=true,
format='s',
logBase1Y=2,
description='TiProxy uptime since the last restart.',
)
.addTarget(
Expand All @@ -214,8 +215,9 @@ local durationP = graphPanel.new(
title='Duration',
datasource=myDS,
legend_rightSide=true,
description='TiProxy query durations by histogram buckets with different percents.',
format='s',
logBase1Y=2,
description='TiProxy query durations by histogram buckets with different percents.',
)
.addTarget(
prometheus.target(
Expand All @@ -242,6 +244,7 @@ local durByInstP = graphPanel.new(
legend_rightSide=true,
description='TiProxy P99 query durations by TiProxy instances.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -256,6 +259,7 @@ local durByBackP = graphPanel.new(
legend_rightSide=true,
description='TiProxy P99 query durations by backends.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -270,6 +274,7 @@ local cpsByInstP = graphPanel.new(
legend_rightSide=true,
description='TiProxy query total statistics including both successful and failed ones.',
format='short',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -284,6 +289,7 @@ local cpsByBackP = graphPanel.new(
legend_rightSide=true,
description='MySQL command statistics by backends.',
format='short',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -298,6 +304,7 @@ local cpsByCMDP = graphPanel.new(
legend_rightSide=true,
description='MySQL command statistics by command type',
format='short',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -312,6 +319,7 @@ local hsDurP= graphPanel.new(
legend_rightSide=true,
description='TiProxy handshake durations by different percents.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand Down Expand Up @@ -354,6 +362,7 @@ local bMigCounterP = graphPanel.new(
legend_rightSide=true,
description='OPM of session migrations on all backends.',
format='short',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -368,6 +377,7 @@ local bMigDurP = graphPanel.new(
legend_rightSide=true,
description='Duration of session migrations.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -394,6 +404,7 @@ local bMigReasonP = graphPanel.new(
legend_rightSide=true,
description='Reasons of session migrations per minute.',
format='short',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -410,6 +421,7 @@ local bGetDurP = graphPanel.new(
legend_rightSide=true,
description='Duration of getting an available backend.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -436,6 +448,7 @@ local bPingBeP = graphPanel.new(
legend_rightSide=true,
description='Duration of Pinging backends.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand All @@ -451,6 +464,7 @@ graphPanel.new(
legend_rightSide=true,
description='Duration of each health check cycle.',
format='s',
logBase1Y=2,
)
.addTarget(
prometheus.target(
Expand Down