Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup update --self will break root.json when using offline package #658

Closed
lucklove opened this issue Aug 5, 2020 · 0 comments · Fixed by #659
Closed

tiup update --self will break root.json when using offline package #658

lucklove opened this issue Aug 5, 2020 · 0 comments · Fixed by #659
Labels
type/bug Categorizes issue as related to a bug.

Comments

@lucklove
Copy link
Member

lucklove commented Aug 5, 2020

The reason is that the clone command doesn't unpack and replace the root.json in tiup.tar.gz, so the root.json in tiup.tar.gz is the same as the online mirror.

The result is that after executing tiup update --self with the offline package, the manifests from the offline package will be recognized as invalid.

image
@lucklove lucklove added type/bug Categorizes issue as related to a bug. status/WIP labels Aug 5, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Aug 5, 2020
@lucklove
Fix tiup update --self with offline package
f83e459 
Fix pingcap#658

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove mentioned this issue Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tiup update --self with offline package lucklove/tiup
1 participant
@lucklove