Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiup update --self with offline package #659

Merged
merged 5 commits into from
Aug 10, 2020

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Aug 5, 2020

Fix #658

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix the issue that `tiup update --self` may make root.json invalid with offline mirror

Fix pingcap#658

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #659 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   57.35%   57.35%   -0.01%     
==========================================
  Files         243      243              
  Lines       17516    17518       +2     
==========================================
  Hits        10047    10047              
- Misses       6167     6169       +2     
  Partials     1302     1302              
Flag Coverage Δ
#coverage 57.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/src/github.com/pingcap/tiup/pkg/utils/ioutil.go 47.54% <0.00%> (-1.64%) ⬇️
...src/github.com/pingcap/tiup/pkg/environment/env.go 37.76% <0.00%> (-0.41%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 59.75% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acff16...1757c4b. Read the comment docs.

Signed-off-by: lucklove <gnu.crazier@gmail.com>
pkg/environment/env.go Outdated Show resolved Hide resolved
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove added this to the v1.1.0 milestone Aug 10, 2020
@lucklove lucklove self-assigned this Aug 10, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2020
@lonng
Copy link
Contributor

lonng commented Aug 10, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lonng lonng removed the status/PTAL label Aug 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 788839c into pingcap:master Aug 10, 2020
@lonng lonng deleted the fix-clone branch August 10, 2020 13:29
@lonng
Copy link
Contributor

lonng commented Aug 10, 2020

@lucklove Please write the release note for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup update --self will break root.json when using offline package
4 participants