Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The monitoring service should be handled more carefully #697

Closed
lucklove opened this issue Aug 20, 2020 · 0 comments · Fixed by #1088
Closed

The monitoring service should be handled more carefully #697

lucklove opened this issue Aug 20, 2020 · 0 comments · Fixed by #1088
Assignees
@lucklove
Labels
category/monitoring Categorizes issue or PR related to monitoring components. status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Milestone
v1.4.0

Comments

@lucklove
Copy link
Member

Bug Report

When we try to stop or disable a node, it will stop or disable the monitoring service(node_exporter & blackbox_exporter) regardless if there are other service still running on that node.

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

tiup cluster stop test -N xxx.xxx.xxx.xxx:port
tiup cluster disable test -N xxx.xxx.xxx.xxx:port

  1. What did you expect to see?
    Only the specified node should be stoped

  2. What did you see instead?
    The monitoring services are stoped too.
@lucklove lucklove added type/bug Categorizes issue as related to a bug. status/TODO Categorizes issue as we will do it. labels Aug 20, 2020
@lucklove lucklove self-assigned this Aug 20, 2020
@lucklove lucklove mentioned this issue Aug 20, 2020
Merged
3 tasks
@lucklove lucklove added this to the v1.2.2 milestone Oct 12, 2020
@lonng lonng modified the milestones: v1.2.2, v1.3.0 Nov 4, 2020
@lucklove lucklove modified the milestones: v1.3.0, v1.3.1 Dec 14, 2020
@lucklove lucklove modified the milestones: v1.3.1, v1.3.2 Dec 25, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Jan 22, 2021
@lucklove
Fix the issue that tiup-cluster disable monitoring service regardless…
4f66ce7 
… if there are other service still running on that node.

Fix pingcap#697
@lucklove lucklove mentioned this issue Jan 22, 2021
Merged
ti-chi-bot added a commit that referenced this issue Jan 25, 2021
@lucklove @ti-chi-bot
Fix the issue that tiup-cluster disable monitoring service regardless…
09833d6 
… if there are other service still running on that node. (#1088)

Fix #697

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
@AstroProfundis AstroProfundis added the category/monitoring Categorizes issue or PR related to monitoring components. label Jan 26, 2021
@lucklove lucklove modified the milestones: v1.3.2, v1.4.0 Jan 27, 2021
mianhk pushed a commit to mianhk/tiup that referenced this issue Jan 29, 2021
@lucklove @ti-chi-bot @mianhk
Fix the issue that tiup-cluster disable monitoring service regardless…
bd45e99 
… if there are other service still running on that node. (pingcap#1088)

Fix pingcap#697

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
AstroProfundis pushed a commit that referenced this issue Mar 24, 2021
@lucklove @ti-chi-bot @AstroProfundis
Fix the issue that tiup-cluster disable monitoring service regardless…
9b0e00c 
… if there are other service still running on that node. (#1088)

Fix #697

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucklove lucklove

Labels
category/monitoring Categorizes issue or PR related to monitoring components. status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Fix the issue that tiup-cluster disable monitoring service unexpected lucklove/tiup
3 participants
@AstroProfundis @lonng @lucklove