-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that tiup-cluster disable monitoring service unexpected #1088
Conversation
… if there are other service still running on that node. Fix pingcap#697
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
===========================================
- Coverage 56.55% 40.95% -15.61%
===========================================
Files 283 282 -1
Lines 20014 20014
===========================================
- Hits 11319 8196 -3123
- Misses 6938 10504 +3566
+ Partials 1757 1314 -443
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4f66ce7
|
@lucklove: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
… if there are other service still running on that node. (pingcap#1088) Fix pingcap#697 Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Fix #697