Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default description #1132

Merged
merged 5 commits into from
Feb 8, 2021
Merged

add default description #1132

merged 5 commits into from
Feb 8, 2021

Conversation

wangbincmsss
Copy link
Contributor

What problem does this PR solve?

when tuip deploy
image
deafult choice is N, but here is no default description

What is changed and how it works?

Attention:
1. If the topology is not what you expected, check your yaml file.
2. Please confirm there is no port/directory conflicts in same host.
Do you want to continue? [y/N] (default=N):

have a default description

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2021
@wangbincmsss
Copy link
Contributor Author

wangbincmsss commented Feb 5, 2021

/cc @july2993 @birdstorm @breeswish

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • birdstorm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@AstroProfundis
Copy link
Contributor

Ummm, the capital N in [y/N] is suggesting N is the default value...

If you would add a more expanded note about current default value, please add it in the pkg/cliutil/tui.go file.

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #1132 (2a57399) into master (333b517) will decrease coverage by 4.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   56.54%   52.45%   -4.10%     
==========================================
  Files         285      285              
  Lines       20243    20243              
==========================================
- Hits        11447    10618     -829     
- Misses       7034     7969     +935     
+ Partials     1762     1656     -106     
Flag Coverage Δ
cluster 38.96% <50.00%> (-5.97%) ⬇️
dm 25.49% <50.00%> (+0.08%) ⬆️
integrate 46.70% <50.00%> (-4.26%) ⬇️
playground 20.86% <ø> (ø)
tiup 16.34% <0.00%> (+0.02%) ⬆️
unittest 22.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cliutil/tui.go 59.18% <0.00%> (ø)
pkg/cluster/manager/manager.go 69.23% <100.00%> (ø)
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/check.go 5.97% <0.00%> (-63.86%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-54.55%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-49.46%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b517...884aa53. Read the comment docs.

@wangbincmsss
Copy link
Contributor Author

wangbincmsss commented Feb 7, 2021

Ummm, the capital N in [y/N] is suggesting N is the default value...

If you would add a more expanded note about current default value, please add it in the pkg/cliutil/tui.go file.

OK I add it in pkg/cliutil/tui.go file. @AstroProfundis

@AstroProfundis
Copy link
Contributor

Thanks, that looks good to me. There is another func PromptForConfirmYes() as well, could you please modify that as well?

@AstroProfundis
Copy link
Contributor

Ah, the description is not correct.

  • PromptForConfirmNo() wait for user to input a No and defaults to yes (if not matching No then assume yes)
  • PromptForConfirmYes() wait for user to input a Yes and defaults to no (if not matching Yes then assume no)

@wangbincmsss
Copy link
Contributor Author

Ah, the description is not correct.

  • PromptForConfirmNo() wait for user to input a No and defaults to yes (if not matching No then assume yes)
  • PromptForConfirmYes() wait for user to input a Yes and defaults to no (if not matching Yes then assume no)

en , my error , I will PromptForConfirmNo in other pull request @AstroProfundis

@ti-chi-bot
Copy link
Member

@wangbinhe3db: GitHub didn't allow me to request PR reviews from the following users: 9547.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @9547

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@9547
Copy link
Contributor

9547 commented Feb 8, 2021

/lgtm

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9dacb18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2021
@ti-chi-bot ti-chi-bot merged commit 2a771a1 into pingcap:master Feb 8, 2021
@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. type/enhancement Categorizes issue or PR as related to an enhancement. labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. first-time-contributor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants