-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default description #1132
add default description #1132
Conversation
/cc @july2993 @birdstorm @breeswish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Ummm, the capital If you would add a more expanded note about current default value, please add it in the |
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
- Coverage 56.54% 52.45% -4.10%
==========================================
Files 285 285
Lines 20243 20243
==========================================
- Hits 11447 10618 -829
- Misses 7034 7969 +935
+ Partials 1762 1656 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
OK I add it in |
Thanks, that looks good to me. There is another func |
Ah, the description is not correct.
|
en , my error , I will PromptForConfirmNo in other pull request @AstroProfundis |
@wangbinhe3db: GitHub didn't allow me to request PR reviews from the following users: 9547. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9dacb18
|
What problem does this PR solve?
when tuip deploy
deafult choice is N, but here is no default description
What is changed and how it works?
Attention:
1. If the topology is not what you expected, check your yaml file.
2. Please confirm there is no port/directory conflicts in same host.
Do you want to continue? [y/N] (default=N):
have a default description
Check List
Tests
Code changes
Side effects
Related changes
Release notes: