-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PromptForConfirmYes default description" #1134
Conversation
/cc @birdstorm @breeswish @9547 |
@wangbinhe3db: GitHub didn't allow me to request PR reviews from the following users: birdstorm, 9547. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0997811
|
@wangbinhe3db: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
===========================================
- Coverage 56.56% 34.27% -22.29%
===========================================
Files 285 282 -3
Lines 20258 20185 -73
===========================================
- Hits 11458 6918 -4540
- Misses 7035 12211 +5176
+ Partials 1765 1056 -709
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
when edit topo file err
New topology could not be saved: Failed to parse topology file: yaml: line 3: could not find expected ':'
Do you want to continue editing? [Y/n]:
deafult choice is Y,
no default description
This PR is a following up of #1132
What is changed and how it works?
New topology could not be saved: Failed to parse topology file: yaml: line 3: could not find expected ':'
Do you want to continue editing? [Y/n]: (default=Y)
deafult choice is Y,
have a default description
Check List
Tests
Code changes
Side effects
Related changes
Release notes: