Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PromptForConfirmYes default description" #1134

Merged
merged 8 commits into from
Feb 9, 2021

Conversation

wangbincmsss
Copy link
Contributor

@wangbincmsss wangbincmsss commented Feb 9, 2021

What problem does this PR solve?

when edit topo file err
New topology could not be saved: Failed to parse topology file: yaml: line 3: could not find expected ':'
Do you want to continue editing? [Y/n]:
deafult choice is Y,
no default description

This PR is a following up of #1132

What is changed and how it works?

New topology could not be saved: Failed to parse topology file: yaml: line 3: could not find expected ':'
Do you want to continue editing? [Y/n]: (default=Y)
deafult choice is Y,
have a default description

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2021
@wangbincmsss
Copy link
Contributor Author

/cc @birdstorm @breeswish @9547

@ti-chi-bot ti-chi-bot requested a review from breezewish February 9, 2021 06:20
@ti-chi-bot
Copy link
Member

@wangbinhe3db: GitHub didn't allow me to request PR reviews from the following users: birdstorm, 9547.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @birdstorm @breeswish @9547

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2021
@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. type/enhancement Categorizes issue or PR as related to an enhancement. labels Feb 9, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0997811

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2021
@ti-chi-bot
Copy link
Member

@wangbinhe3db: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #1134 (51bcda5) into master (6cf73b3) will decrease coverage by 22.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1134       +/-   ##
===========================================
- Coverage   56.56%   34.27%   -22.29%     
===========================================
  Files         285      282        -3     
  Lines       20258    20185       -73     
===========================================
- Hits        11458     6918     -4540     
- Misses       7035    12211     +5176     
+ Partials     1765     1056      -709     
Flag Coverage Δ
cluster ?
dm 20.21% <0.00%> (-5.23%) ⬇️
integrate 23.58% <0.00%> (-27.40%) ⬇️
playground 20.96% <ø> (ø)
tiup ?
unittest 22.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cliutil/tui.go 59.18% <0.00%> (ø)
main.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/task/update_dm_meta.go 0.00% <0.00%> (-85.30%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/spec/bindversion.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/manager/display.go 0.00% <0.00%> (-81.95%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf73b3...51bcda5. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 97cd5cb into pingcap:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants