Pino 7 new transport interface #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
commented
Sep 13, 2021
test/transport.js
Outdated
| log.fatal(new Error('ops'), 'not ignored') | ||
| t.pass('logged on mongo') | ||
|
|
||
| await setTimeout(1000) |
There was a problem hiding this comment.
Here, I did not found a way to wait pino.flush() (and it was triggering an error. I'm investigating)
kibertoad
reviewed
Sep 13, 2021
mcollina
reviewed
Sep 13, 2021
climba03003
reviewed
Sep 14, 2021
|
there appear to be some conflicts |
Done |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pinojs/pino#1056
Main changes:
useUnifiedTopologyanduseNewUrlParseroptions. Since mongo client v4 these options are ignored - this module uses the 4.1 sticky versionpino-abstract-transportutilitycli's logic as new pino v7 transportDo you have some tests to suggest?
Do you think that we could use the mongo's bulk write to insert rows? - if so, what frequency?
Todo: