Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 release planning #1056

Closed
13 tasks done
mcollina opened this issue Jul 8, 2021 · 28 comments
Closed
13 tasks done

v7 release planning #1056

mcollina opened this issue Jul 8, 2021 · 28 comments

Comments

@mcollina
Copy link
Member

mcollina commented Jul 8, 2021

I think it's time we ship v7. This is a tracking issue of all things we should do:

After release:

@mcollina
Copy link
Member Author

mcollina commented Jul 8, 2021

@jsumners @davidmarkclements @kibertoad wdyt?

@kibertoad
Copy link
Contributor

@mcollina We dropped engines part from package.json, and there is no documentation entry explaining supported versions, and it's not very intuitive for people to check CI config to figure out what is supported. Are we only going to communicate the change via release notes?

@kibertoad
Copy link
Contributor

Maybe we should also bump dependencies all across the board as well?

@mcollina
Copy link
Member Author

mcollina commented Jul 8, 2021

@mcollina We dropped engines part from package.json, and there is no documentation entry explaining supported versions, and it's not very intuitive for people to check CI config to figure out what is supported. Are we only going to communicate the change via release notes?

Aggreed!

@mcollina
Copy link
Member Author

mcollina commented Jul 8, 2021

Maybe we should also bump dependencies all across the board as well?

I think we are already up-to-date. Some of the dependencies moved to esm so they cannot be updated. We might want to consider forking or replacing instead.

@kibertoad
Copy link
Contributor

@mcollina Can't we tackle the ESM requirement after v7 lands, by dropping 12 for v8 next?

@mcollina
Copy link
Member Author

mcollina commented Jul 8, 2021

@mcollina Can't we tackle the ESM requirement after v7 lands, by dropping 12 for v8 next?

I would open a separate issue to discuss ESM migration. My stance on this has not changed: until there is a clear way for APMs to use ESM, we cannot migrate. Node.js v16 does not have such a mechanism, so I think we are targeting many years of cjs still.

@jsumners
Copy link
Member

jsumners commented Jul 8, 2021

The list looks good. Probably easier to track via a project, but 🤷‍♂️

@mcollina mcollina pinned this issue Jul 9, 2021
@mcollina
Copy link
Member Author

mcollina commented Jul 9, 2021

Do we want to start issuing release candidates before or after the merge of next into master?

@jsumners
Copy link
Member

jsumners commented Jul 9, 2021

After seems appropriate.

@mcollina
Copy link
Member Author

@jsumners I have prepared the release notes: https://github.com/pinojs/pino/releases/edit/untagged-dbc8943e8571f30c52c1.

Let me know what you think

@jsumners
Copy link
Member

@jsumners I have prepared the release notes: pinojs/pino/releases/edit/untagged-dbc8943e8571f30c52c1.

Let me know what you think

Superb!

@kibertoad
Copy link
Contributor

kibertoad commented Jul 20, 2021

@mcollina Is there a reason why we use old var syntax in release notes examples?
Also TS types might need slightly more emphasis, especially since they are a breaking change for those who used to rely on DefinitelyTyped ones. Mentioning the need to migrate and drop the redundant dependency would probably be helpful.

@jsumners
Copy link
Member

They do mention the need to drop the old types package.

@kibertoad
Copy link
Contributor

kibertoad commented Jul 20, 2021

@jsumners Awww, sorry, somehow managed to miss the whole section on TypeScript, only saw it mentioned in the merged pull request list, hence my comment. Yes, it is good now.

@mcollina
Copy link
Member Author

pino@7.0.0-rc.1 is out on npm.

@vladshcherbin
Copy link
Contributor

Hey 👋 I've tried to use pino-papertrail with pino v7 as in transport docs example, seems to be working. Would be nice if any of maintainers could check, I'm a pino novice. Here's linked issue with example inside:

ovhemert/pino-papertrail#48

@mcollina
Copy link
Member Author

mcollina commented Aug 9, 2021

I have updated the todo list at the top with a list of modules to port.

@jsumners
Copy link
Member

jsumners commented Aug 9, 2021

pino-arborsculpture is not a transport.

@mcollina
Copy link
Member Author

mcollina commented Aug 9, 2021

removed!

@Eomm
Copy link
Contributor

Eomm commented Sep 3, 2021

add transport support to pino-socket

working on it

@Eomm
Copy link
Contributor

Eomm commented Sep 10, 2021

add transport support to pino-mongodb

Working on it

@zgwit
Copy link

zgwit commented Sep 19, 2021

@mcollina I am glade to ship pino@v7. can i use it now?

@mcollina
Copy link
Member Author

I think it would be great!

@mcollina
Copy link
Member Author

I'm planning to ship v7 on Thursday, October 14th.

@jsumners
Copy link
Member

rick-flair-woo

@mcollina
Copy link
Member Author

@mcollina mcollina unpinned this issue Oct 14, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants