Pino 7 upgrade #13
Pino 7 upgrade #13
Conversation
Co-authored-by: James Sumners <james@sumners.email>
|
Not sure it matters since this should be a new major, but tests are failing on 12. |
|
We are still supporting v12 in pino@7. |
Then tests should pass. |
|
They are independent modules. We don't know what people do with the socket module. It's really, really, generic and can be used for many things even outside of Pino logs. It should remain a standalone module. Instead, we should be able to pipe transports into one another. |
|
I meant to add that functionality here, not viceversa as this module is supposed to work with pino-socket. |
I will try to integrate it |
| t.teardown(() => { | ||
| serverSocket.close() | ||
| serverSocket.unref() | ||
| transport.end() |
There was a problem hiding this comment.
I had to add this line to make it works on node12.
I thought it was due the duplexyfy stream, that accepts these two parameters:
autoDestroy: true,
destroy: true
But it was not.
Nether the underlining socket.unref() was the issue.
I would like to understand why the transport doesn't close.
I still don not figured it out.
There was a problem hiding this comment.
What was the problem? why the test did not pass? It might be a bug in my code.
There was a problem hiding this comment.
tap triggers a timeout error - locally within an infinity timeout, the process does not end without any errors
|
@Eomm pino@7.0.0-rc.8 is out, you can use update this and use |
Done |
|
There is something else I can do on this PR? |
|
@jsumners anything left for you? |
Ref pinojs/pino#1056